Centralize docs processing in openhab-docs#560
Draft
jimtng wants to merge 15 commits into
Draft
Conversation
Remove duplicated openhab-docs processing code from the openhab-website repository and source the logic from the openhab-docs repository. During website preprocessing the openhab-docs repo is cloned into a temporary directory and its docs-processing code is loaded from that clone, ensuring the website build always uses the latest processing logic. This eliminates duplication, reduces maintenance overhead, and makes docs processing a single source of truth. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Contributor
Author
|
Deploy was successful. Deploy preview: https://deploy-preview-560--openhab.netlify.app/ |
Contributor
Author
|
Note: future cleanup of |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Contributor
Author
|
I won't have a lot of availability in the next month. Switching this to draft for now. |
Contributor
|
Once I am finished with reviewing everything that we want in 5.2, I can test and finish this. |
Contributor
Author
|
Feel free to continue on it. I think it's done pending review. I won't be completely offline. Also I hope @ccutrer can help review the ruby bits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated openhab-docs processing code from the openhab-website
repository and source the logic from the openhab-docs repository.
During website preprocessing the openhab-docs repo is cloned into a
temporary directory and its docs-processing code is loaded from that
clone, ensuring the website build always uses the latest processing
logic. This eliminates duplication, reduces maintenance overhead, and
makes docs processing a single source of truth.
Depends on openhab/openhab-docs#2718
This PR currently performs copying temporary shims to successfully build while the docs PR is not yet merged. Once the docs PR is merged and an openhabian docs get pushed with the updated action from openhab/openhab-docs#2718 we can update this to remove the additional process, although it should be harmless if it isn't removed immediately.