Skip to content

Bump Mypy #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mattwthompson wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Bump Mypy #2181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c27c0f
Bump Mypy
mattwthompson May 14, 2026
b361ab8
Allow 2.0, 2.1 conda builds do not yet exist
mattwthompson May 14, 2026
5dfb0c6
Just use PyPI
mattwthompson May 14, 2026
b17860b
Syntax
mattwthompson May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devtools/conda-envs/openeye.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ dependencies:
- qcengine
- mdtraj
- nglview
- mypy =1.18
- typing_extensions
- pip:
- mypy ==2
- types-setuptools
- types-toml
- types-PyYAML
Expand Down
2 changes: 1 addition & 1 deletion openff/toolkit/topology/molecule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5654,7 +5654,7 @@ def _networkx_graph_to_hill_formula(graph: "nx.Graph[int]") -> str:
if not isinstance(graph, nx.Graph):
raise ValueError("The graph must be a NetworkX graph.")

atom_nums: list[int] = [atomic_number for (_, atomic_number) in graph.nodes(data="atomic_number", default=1)]
atom_nums: list[int] = [atomic_number for (_, atomic_number) in graph.nodes(data="atomic_number", default=1)] # type: ignore[misc]
Comment thread
mattwthompson marked this conversation as resolved.

return _atom_nums_to_hill_formula(atom_nums) # type:ignore[arg-type]

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ lint.isort.known-third-party = [ "openff.interchange", "openff.utilities", "open

[tool.mypy]
python_version = 3.12
plugins = "numpy.typing.mypy_plugin"
warn_unused_configs = true
# would be nice to flip back to true
warn_unused_ignores = false
Expand Down
Loading