Macsec test Implementation#5399
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new automated test suite for validating MACsec functionality. It includes logic to configure MACsec profiles, verify secure status, check Connectivity Association Key Name (CKN) matching, and monitor various hardware counters related to MACsec operations. The changes also extend the testing infrastructure to support these new validations through updated metadata and deviation handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a MACsec test suite for DUT-to-DUT scenarios, including configuration and telemetry verification for state and counters. It also adds the necessary proto fields and deviation accessors for Arista platforms. The review identified a missing import for the gNOI system package and noted that the new deviation accessor functions lack the required issue tracker links in their documentation.
…ect imports Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Pull Request Functional Test Report for #5399 / 92496c8Virtual Devices
Hardware Devices
|
* Macsec test Implementation * Log error when counter is missing * Update feature/macsec/otg_tests/macsec/macsec_test.go to include correct imports Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Use random keys * Fix imports * Fix further imports --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.