Skip to content

Macsec test Implementation#5399

Merged
RishabhAgarwal-2001 merged 9 commits intomainfrom
rishabh/macsec-impl
Apr 30, 2026
Merged

Macsec test Implementation#5399
RishabhAgarwal-2001 merged 9 commits intomainfrom
rishabh/macsec-impl

Conversation

@RishabhAgarwal-2001
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new automated test suite for validating MACsec functionality. It includes logic to configure MACsec profiles, verify secure status, check Connectivity Association Key Name (CKN) matching, and monitor various hardware counters related to MACsec operations. The changes also extend the testing infrastructure to support these new validations through updated metadata and deviation handling.

Highlights

  • New MACsec Test Implementation: Added a comprehensive test suite in Go to verify MACsec configuration, status reporting, and hardware exception counters on Arista devices.
  • Metadata and Deviation Updates: Updated metadata protocols and deviation definitions to support MACsec state and counter functional translators.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a MACsec test suite for DUT-to-DUT scenarios, including configuration and telemetry verification for state and counters. It also adds the necessary proto fields and deviation accessors for Arista platforms. The review identified a missing import for the gNOI system package and noted that the new deviation accessor functions lack the required issue tracker links in their documentation.

Comment thread feature/macsec/otg_tests/macsec/macsec_test.go
Comment thread internal/deviations/deviations.go
Comment thread internal/deviations/deviations.go
RishabhAgarwal-2001 and others added 2 commits April 29, 2026 12:22
…ect imports

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread feature/macsec/otg_tests/macsec/macsec_test.go Outdated
Comment thread feature/macsec/otg_tests/macsec/macsec_test.go Outdated
Comment thread feature/macsec/otg_tests/macsec/macsec_test.go Outdated
@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 30, 2026

@RishabhAgarwal-2001 RishabhAgarwal-2001 merged commit edba33a into main Apr 30, 2026
17 of 18 checks passed
@RishabhAgarwal-2001 RishabhAgarwal-2001 deleted the rishabh/macsec-impl branch April 30, 2026 10:08
rolandphung pushed a commit to rolandphung/featureprofiles that referenced this pull request May 1, 2026
* Macsec test Implementation

* Log error when counter is missing

* Update feature/macsec/otg_tests/macsec/macsec_test.go to include correct imports

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Use random keys

* Fix imports

* Fix further imports

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants