Skip to content

Update interface state check and add wait after config push #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyaranjannanda wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

Update interface state check and add wait after config push #5396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c217c
Updated correct interface state check and added wait after config push
priyaranjannanda Apr 28, 2026
c76295a
Merge branch 'main' into TRANSCIVER-107_1
priyaranjannanda Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions internal/telemetry/transceiver/zr_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
const (
samplingInterval = 10 * time.Second
errorTolerance = 0.05
timeout = 10 * time.Minute
timeout = 15 * time.Minute
)

var (
Expand Down Expand Up @@ -160,6 +160,10 @@ func PlatformPathsTest(t *testing.T, tp *TunableParamters) {
batch := &gnmi.SetBatch{}
cfgplugins.NewInterfaceConfigAll(t, dut, batch, params)
batch.Set(t, dut)
// Wait for the config to be applied and the telemetry stream to be updated.
// Note: The sleep is added to ensure that the telemetry is updated after the config push.
// This is required as some platforms may take time to update the telemetry after the config is applied.
time.Sleep(120 * time.Second)

// Create sample steams for each port.
ochStreams := make(map[string]*samplestream.SampleStream[*oc.Component])
Expand Down Expand Up @@ -197,7 +201,7 @@ func PlatformPathsTest(t *testing.T, tp *TunableParamters) {
for _, p := range dut.Ports() {
validateInterfaceTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, interfaceStreams[p.Name()])
validateTranscieverTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, trStreams[p.Name()])
validateTempSensorTelemetry(t, dut, p, params, oc.Interface_OperStatus_DOWN, tempSensorStreams[p.Name()])
validateTempSensorTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, tempSensorStreams[p.Name()])
validateOpticalChannelTelemetry(t, p, params, oc.Interface_OperStatus_UP, ochStreams[p.Name()])
validateHWPortTelemetry(t, dut, p, params, hwPortStreams[p.Name()])
}
Expand All @@ -223,7 +227,7 @@ func PlatformPathsTest(t *testing.T, tp *TunableParamters) {
for _, p := range dut.Ports() {
validateInterfaceTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, interfaceStreams[p.Name()])
validateTranscieverTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, trStreams[p.Name()])
validateTempSensorTelemetry(t, dut, p, params, oc.Interface_OperStatus_DOWN, tempSensorStreams[p.Name()])
validateTempSensorTelemetry(t, dut, p, params, oc.Interface_OperStatus_UP, tempSensorStreams[p.Name()])
validateOpticalChannelTelemetry(t, p, params, oc.Interface_OperStatus_UP, ochStreams[p.Name()])
validateHWPortTelemetry(t, dut, p, params, hwPortStreams[p.Name()])
}
Expand Down
Loading