Update and Refactor PLT-1.3

[AmrNJ]

Refactored breakout subscription test to improve stream handling, path/value verification, and line card discovery.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the breakout subscription test suite to improve the reliability and accuracy of gNMI stream handling and component verification. By moving to a buffered channel-based stream reader and enhancing the logic for parsing and verifying OpenConfig notifications, the changes ensure that the tests can correctly interpret state updates even when they are grouped or nested. Additionally, the update improves line card discovery and adds necessary stability fixes for reboot-related test scenarios.

Highlights

• Stream Handling Refactor: Introduced a dedicated goroutine and buffered channel (startStreamReader) to safely handle gRPC stream notifications, preventing potential concurrency issues during test execution.
• Verification Logic Improvements: Enhanced verifyNotificationPaths and verifyUpdateValue to better handle parent-level grouping and JSON-encoded values, improving the robustness of state verification.
• Line Card Discovery: Updated findLinecardFromPort to dynamically traverse the OpenConfig component hierarchy, making line card identification more reliable across different device types.
• Test Stability: Increased timeout values and added channel draining mechanisms to ensure tests are less flaky and more resilient to control plane latency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5394 / 2eeaa57

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	67bc0ec7	Log
Cisco 8000E		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	540f6b52	Log
Cisco XRd		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	da44ef50	Log
Juniper ncPTX		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	f5568f44	Log
Nokia SR Linux		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	b023ed85	Log
Openconfig Lemming		PLT-1.3: OnChange Subscription Test for Breakout Interfaces	7d318e10	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Cisco 8808		PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Juniper PTX10008		PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Nokia 7250 IXR-10e		PLT-1.3: OnChange Subscription Test for Breakout Interfaces

Help

[gemini-code-assist]

Code Review

This pull request refactors the breakout subscription test to enhance reliability and hardware compatibility. It introduces a channel-based gNMI stream reader to prevent concurrency issues and replaces regex-based linecard identification with dynamic gNMI hierarchy traversal. Additionally, verification logic is updated to handle grouped JSON updates and vendor-specific statuses. Feedback highlights critical issues including potential panics due to missing port count validations, a missing 'slices' package import, and logic errors in linecard quantity checks.

[ram-mac]

@AmrNJ - There are static failure checks, fix them