Skip to content

Update system_ntp_test.go #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmrNJ merged 6 commits into from
Apr 30, 2026
+34 −15
Merged

Update system_ntp_test.go #5393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fecae04
Update system_ntp_test.go
AmrNJ Apr 28, 2026
2ce9aa6
Update system_ntp_test.go
AmrNJ Apr 29, 2026
d871035
Update metadata.textproto
AmrNJ Apr 29, 2026
99da0ab
Update system_ntp_test.go
AmrNJ Apr 29, 2026
32e340c
gofmt
AmrNJ Apr 29, 2026
a401330
Merge branch 'main' into AmrNJ-patch-4
AmrNJ Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion feature/system/ntp/tests/system_ntp_test/metadata.textproto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,12 @@ platform_exceptions: {
deviations: {
ntp_source_address_unsupported: true
}
}
}
platform_exceptions: {
platform: {
vendor: ARISTA
}
deviations: {
default_network_instance: "default"
}
}
39 changes: 25 additions & 14 deletions feature/system/ntp/tests/system_ntp_test/system_ntp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,15 @@ var (

// TestNtpServerConfigurability validates that NTP servers can be configured on the DUT.
func TestNtpServerConfigurability(t *testing.T) {
dut := ondatra.DUT(t, "dut")
loopbackIntfName := netutil.LoopbackInterface(t, dut, loopbackIntf[dut.Vendor()])

defaultVrf := deviations.DefaultNetworkInstance(dut)

if dut.Vendor() == ondatra.NOKIA {
helpers.GnmiCLIConfig(t, dut, "/ system delete ntp")
}

testCases := []struct {
description string
addresses []string
Expand All @@ -58,13 +67,13 @@ func TestNtpServerConfigurability(t *testing.T) {
{
description: "4x IPv4 NTP in default VRF",
addresses: []string{"192.0.2.1", "192.0.2.2", "192.0.2.3", "192.0.2.4"},
vrf: "DEFAULT",
vrf: defaultVrf,
ipv4: true,
},
{
description: "4x IPv6 NTP (RFC5952) in default VRF",
addresses: []string{"2001:db8::1", "2001:db8::2", "2001:db8::3", "2001:db8::4"},
vrf: "DEFAULT",
vrf: defaultVrf,
ipv4: false,
},
{
Expand All @@ -81,10 +90,8 @@ func TestNtpServerConfigurability(t *testing.T) {
},
}

dut := ondatra.DUT(t, "dut")
loopbackIntfName := netutil.LoopbackInterface(t, dut, loopbackIntf[dut.Vendor()])
for _, testCase := range testCases {
if testCase.vrf != "" {
if testCase.vrf != defaultVrf {
createVRF(t, dut, testCase.vrf)
addLoopbackToVRF(t, dut, testCase.vrf, loopbackIntfName)
}
Expand All @@ -95,44 +102,46 @@ func TestNtpServerConfigurability(t *testing.T) {
if deviations.NtpSourceAddressUnsupported(dut) {
t.Run(testCase.description, func(t *testing.T) {
for _, address := range testCase.addresses {
if testCase.vrf != "" {
if testCase.vrf != defaultVrf {
ntpServer := fmt.Sprintf("ntp server vrf %s %s version 4 source %s ", testCase.vrf, address, loopbackIntfName)
helpers.GnmiCLIConfig(t, dut, ntpServer)
} else {
ntpServer := fmt.Sprintf("ntp server %s version 4 source %s ", address, loopbackIntfName)
helpers.GnmiCLIConfig(t, dut, ntpServer)
}
}

ntpPath := gnmi.OC().System().Ntp()
ntpState := gnmi.Get(t, dut, ntpPath.State())

for _, address := range testCase.addresses {
ntpServer := ntpState.GetServer(address)
if ntpServer == nil {
t.Errorf("Missing NTP server from NTP state: %s", address)
}
if got, want := ntpServer.GetNetworkInstance(), testCase.vrf; want != "" && got != want {
t.Errorf("Incorrect NTP Server network instance for address %s: got %s, want %s", address, got, want)

if got, want := ntpServer.GetNetworkInstance(), testCase.vrf; want != defaultVrf && got != want {
t.Errorf("Incorrect NTP Server network instance for address %s: got %s, want %s", address, got, testCase.vrf)
}
}
})
} else {
t.Run(testCase.description, func(t *testing.T) {
ntpPath := gnmi.OC().System().Ntp()

d := &oc.Root{}

ntp := d.GetOrCreateSystem().GetOrCreateNtp()
ntp.SetEnabled(true)

for _, address := range testCase.addresses {
server := ntp.GetOrCreateServer(address)
if testCase.ipv4 {
server.SetSourceAddress(dutlo0Attrs.IPv4)
} else {
server.SetSourceAddress(dutlo0Attrs.IPv6)
}
if testCase.vrf != "" {
server.SetNetworkInstance(testCase.vrf)
}

server.SetNetworkInstance(testCase.vrf)
}

gnmi.Replace(t, dut, ntpPath.Config(), ntp)
Expand All @@ -143,8 +152,9 @@ func TestNtpServerConfigurability(t *testing.T) {
if ntpServer == nil {
t.Errorf("Missing NTP server from NTP state: %s", address)
}
if got, want := ntpServer.GetNetworkInstance(), testCase.vrf; want != "" && got != want {
t.Errorf("Incorrect NTP Server network instance for address %s: got %s, want %s", address, got, want)

if got, want := ntpServer.GetNetworkInstance(), testCase.vrf; want != defaultVrf && got != want {
t.Errorf("Incorrect NTP Server network instance for address %s: got %s, want %s", address, got, testCase.vrf)
}
}
})
Expand All @@ -168,5 +178,6 @@ func addLoopbackToVRF(t *testing.T, dut *ondatra.DUTDevice, vrfname string, loop
i.Description = ygot.String(fmt.Sprintf("Port %s", loopbackIntfName))
si := i.GetOrCreateSubinterface(0)
si.Enabled = ygot.Bool(true)

gnmi.Update(t, dut, gnmi.OC().Interface(loopbackIntfName).Config(), i)
}
Loading