Fixed link and code issue in the test

[keysightgems]

Readme Location: https://github.com/open-traffic-generator/featureprofiles/blob/main/feature/gribi/mpls_in_udp/otg_tests/mpls_over_udp_tunnel_hashing_test/README.md

Attached logs here: https://partnerissuetracker.corp.google.com/u/2/issues/415458482

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the MPLS-over-UDP tunnel hashing test to improve stability and maintainability. The changes primarily focus on refining the testbed configuration, standardizing gRIBI client handling, and optimizing the ARP resolution process during test setup. These adjustments ensure the test environment is correctly provisioned and that resources are managed more reliably throughout the test lifecycle.

Highlights

• Testbed Configuration: Updated the testbed configuration in metadata.textproto from 2 links to 4 links to support the required test topology.
• gRIBI Client Management: Introduced a helper function mustNewGRIBIClient to standardize gRIBI client initialization and lifecycle management, including automatic cleanup.
• ARP Resolution: Replaced generic ARP waiting logic with more specific interface-based ARP resolution checks using cfgplugins.
• Code Cleanup: Removed unused imports and redundant deletion result checks to simplify the test execution flow.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5386 / 9c0c207

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Cisco 8000E		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Cisco XRd		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Juniper ncPTX		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Nokia SR Linux		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Openconfig Lemming		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Cisco 8808		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Juniper PTX10008		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation
Nokia 7250 IXR-10e		TE-18.4: ECMP hashing on outer and inner packets with MPLSoUDP encapsulation

Help

[gemini-code-assist]

Code Review

This pull request updates the MPLS over UDP tunnel hashing test to utilize a 4-link testbed and refactors gRIBI client initialization and cleanup using a helper function and t.Cleanup. Additionally, it replaces manual ARP waiting with cfgplugins calls and simplifies entry cleanup via FlushAll. The review identifies that errors from the new ARP resolution functions are currently ignored and should be handled with t.Fatalf to prevent misleading test results.