Skip to content

certz/test_data: suppress EC PARAMETERS in key file#5372

Open
brianneville wants to merge 1 commit intoopenconfig:mainfrom
brianneville:mk-cert-no-ec
Open

certz/test_data: suppress EC PARAMETERS in key file#5372
brianneville wants to merge 1 commit intoopenconfig:mainfrom
brianneville:mk-cert-no-ec

Conversation

@brianneville
Copy link
Copy Markdown
Contributor

the key file for ECDSA keys was being created
with an additional pem block specifying
EC PARAMETERS, which is not required.

@brianneville brianneville requested a review from a team as a code owner April 22, 2026 15:35
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up the generated ECDSA key files by preventing the inclusion of redundant EC PARAMETERS blocks. By adding the -noout flag to the OpenSSL ecparam command, the output is restricted to the private key itself, ensuring cleaner and more standard-compliant test data.

Highlights

  • ECDSA Key Generation: Updated the OpenSSL command to include the -noout flag when generating ECDSA keys.
  • PEM Block Cleanup: Removed the unnecessary EC PARAMETERS PEM block from the generated key files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 22, 2026

Pull Request Functional Test Report for #5372 / d955a18

No tests identified for validation.

Help

the key file for ECDSA keys was being created
with an additional pem block specifying
EC_PARAMETERS, which is not required.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the mk_cas.sh script to include the -noout flag in openssl ecparam commands during ECDSA key generation, which suppresses parameter output. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants