Adding reboot test covering testing bugs#5370
Adding reboot test covering testing bugs#5370rohit-rp wants to merge 2 commits intoopenconfig:mainfrom
Conversation
Pull Request Functional Test Report for #5370 / b078b5aVirtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces documentation for a new system reboot test designed to verify device stability and control-plane integrity. The test ensures that critical network protocols and connectivity remain functional after a reboot, addressing specific issues related to database entries, chassis reboots, and SSH connectivity. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new test plan for the DUT Reboot Test (System-2.1), covering BGP, IS-IS, and redistribution across reboots. The review feedback focuses on aligning the document structure with the repository's mandatory test plan template, including specific header naming conventions and step numbering. Additionally, the reviewer noted that the 'Canonical OC' section needs to be updated to reflect the actual test configuration and the target platform should be corrected to MFF to match the pull request's intent.
|
|
||
| #### Initial Setup: | ||
|
|
||
| * Connect DUT port-1, 2 to ATE port-1, 2 |
There was a problem hiding this comment.
Procedure steps should be prefixed with "Step X" (e.g., * Step 1 - ...) to align with the template and the style guide requirement for mapping steps to code comments or logs (line 34).
References
- Each step in the test plan procedure should correspond to a comment or t.Log in the code. (link)
| * Validate that the traffic is received on ATE port-2 | ||
|
|
||
| #### Canonical OC | ||
| ```json |
Coverage for:
http://b/418856223 ISIS database entries going missing after a routing process restart
http://b/286086308 Verify chassis reboots with P4RT active
http://b/399612422 SSH connection to the MFF chassis dropping after a reboot