Updated wait time for fabric card oper_status#5369
Updated wait time for fabric card oper_status#5369mnp-juniper wants to merge 5 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the timing parameters for operational status verification in fabric-related tests. By extending the wait time, the tests are less likely to fail due to transient delays in component state transitions. Additionally, a specific test case has been temporarily disabled to refine the test execution flow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request increases the timeout for gnmi.Await operations from 2 to 3 minutes when checking the operational status of fabric components in fabric_redundancy_test.go and sampled_backplane_capacity_counters_test.go. Additionally, it comments out the 'Fabric inventory' test case in the fabric_redundancy_test.go file. I have no feedback to provide.
Updated the waiting time for octomer fabric from 3 minutes to 5 minutes
Updated wait time for octomore fabric card oper-status from 3 minutes to 5 minutes
Updated wait time for fabric card oper_status to be ACTIVE after a power on from 2 minutes to 5 minutes