Skip to content

Updated wait time for fabric card oper_status#5369

Open
mnp-juniper wants to merge 5 commits intoopenconfig:mainfrom
mnp-juniper:fab
Open

Updated wait time for fabric card oper_status#5369
mnp-juniper wants to merge 5 commits intoopenconfig:mainfrom
mnp-juniper:fab

Conversation

@mnp-juniper
Copy link
Copy Markdown
Contributor

@mnp-juniper mnp-juniper commented Apr 21, 2026

Updated wait time for fabric card oper_status to be ACTIVE after a power on from 2 minutes to 5 minutes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the timing parameters for operational status verification in fabric-related tests. By extending the wait time, the tests are less likely to fail due to transient delays in component state transitions. Additionally, a specific test case has been temporarily disabled to refine the test execution flow.

Highlights

  • Wait Time Adjustment: Increased the timeout duration for SIB operational status checks from 2 minutes to 3 minutes across multiple test files to improve test stability.
  • Test Execution: Commented out the 'Fabric inventory' test case in the fabric redundancy test suite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the timeout for gnmi.Await operations from 2 to 3 minutes when checking the operational status of fabric components in fabric_redundancy_test.go and sampled_backplane_capacity_counters_test.go. Additionally, it comments out the 'Fabric inventory' test case in the fabric_redundancy_test.go file. I have no feedback to provide.

@mnp-juniper mnp-juniper changed the title Updated wait time for sib oper_status Updated wait time for fabric card oper_status Apr 21, 2026
Updated the waiting time for octomer fabric from 3 minutes to 5 minutes
Updated wait time for octomore fabric card oper-status from 3 minutes to 5 minutes
@mnp-juniper mnp-juniper marked this pull request as ready for review April 27, 2026 11:11
@mnp-juniper mnp-juniper requested a review from a team as a code owner April 27, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants