Adding TE-14.3: gRIBI Scaling - full scale setup, target T1 Test#5365
Adding TE-14.3: gRIBI Scaling - full scale setup, target T1 Test#5365keysightgems wants to merge 3 commits intoopenconfig:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements the TE-14.3 gRIBI scaling test suite, focusing on a full-scale T1 setup. It introduces a shared configuration framework to handle complex topology, gRIBI programming, and traffic validation, ensuring consistency across different scaling test targets. The changes aim to validate hierarchical route structures and end-to-end traffic forwarding under high-scale conditions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5365 / d599aa0Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds the TE-14.3 gRIBI full-scale test and a shared cfgplugins package for topology and traffic validation. Key feedback includes the need to enable commented-out VRF selection and gRIBI verification logic, and to scale the ARP resolution check to all interfaces. Additionally, the implementation should be refactored to comply with style guidelines regarding configuration plugin signatures, the use of GNMI batching instead of direct sets or replaces, and the replacement of non-deterministic sleep calls with proper waiting mechanisms.
997b453 to
d599aa0
Compare
Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/gribi/otg_tests/gribi_full_scale_t1/README.md
Test cases failing due to the issue https://partnerissuetracker.corp.google.com/u/2/issues/500317744
Logs attached here: https://partnerissuetracker.corp.google.com/u/2/issues/504560249