Skip to content

Adding TE-14.3: gRIBI Scaling - full scale setup, target T1 Test#5365

Open
keysightgems wants to merge 3 commits intoopenconfig:mainfrom
open-traffic-generator:fpt_otg_TE-14.3
Open

Adding TE-14.3: gRIBI Scaling - full scale setup, target T1 Test#5365
keysightgems wants to merge 3 commits intoopenconfig:mainfrom
open-traffic-generator:fpt_otg_TE-14.3

Conversation

@keysightgems
Copy link
Copy Markdown
Contributor

@keysightgems keysightgems commented Apr 20, 2026

@keysightgems keysightgems requested review from a team as code owners April 20, 2026 14:57
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements the TE-14.3 gRIBI scaling test suite, focusing on a full-scale T1 setup. It introduces a shared configuration framework to handle complex topology, gRIBI programming, and traffic validation, ensuring consistency across different scaling test targets. The changes aim to validate hierarchical route structures and end-to-end traffic forwarding under high-scale conditions.

Highlights

  • New Test Implementation: Added the TE-14.3 gRIBI scaling test case (T1 target) to validate full-scale setup and traffic scenarios.
  • Shared Configuration Helpers: Introduced a new internal configuration plugin to centralize topology, gRIBI programming, and traffic validation logic for scaling tests.
  • Metadata Update: Updated metadata for the test case to include platform exceptions for Arista devices.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link
Copy Markdown

OpenConfigBot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the TE-14.3 gRIBI full-scale test and a shared cfgplugins package for topology and traffic validation. Key feedback includes the need to enable commented-out VRF selection and gRIBI verification logic, and to scale the ARP resolution check to all interfaces. Additionally, the implementation should be refactored to comply with style guidelines regarding configuration plugin signatures, the use of GNMI batching instead of direct sets or replaces, and the replacement of non-deterministic sleep calls with proper waiting mechanisms.

Comment thread internal/cfgplugins/gribifullscale.go
Comment thread internal/cfgplugins/gribifullscale.go
Comment thread internal/cfgplugins/gribifullscale.go
Comment thread internal/cfgplugins/gribifullscale.go
Comment thread internal/cfgplugins/gribifullscale.go
Comment thread internal/cfgplugins/gribifullscale.go
@ksgireesha ksgireesha requested a review from gggsmith April 21, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants