gNOI-5.1: Remove std_dev check from ping test

[raviv-arista]

The test pings loopback address where ping RTTs are extremely tight (30-50 us). The variance between packets is typically < 500 ns, which is < 0.0005 ms. Linux ping (iputils) reports mdev rounded to 3 decimal places in ms, so this rounds to mdev = 0.000 ms, and the gNOI server reports std_dev = 0 ns.

The test expectation for ping std_dev > 1 is not correct. Removed std_dev check itself as std_dev will always be greater than or equal to 0.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gNOI ping test suite to remove an incorrect expectation regarding standard deviation. Due to the extremely low latency of loopback pings, the reported standard deviation often rounds to zero, causing the previous test validation to fail unnecessarily. The changes remove the standard deviation check entirely to ensure test stability.

Highlights

• Removed Standard Deviation Check: Removed the validation logic for ping standard deviation from the test suite as it was found to be unreliable for loopback pings with extremely low latency.
• Cleanup of Test Constants: Removed the minimumStdDev constant and associated references to streamline the test configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5364 / 80ce162

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNOI-5.1: Ping Test
Cisco 8000E		gNOI-5.1: Ping Test
Cisco XRd		gNOI-5.1: Ping Test
Juniper ncPTX		gNOI-5.1: Ping Test
Nokia SR Linux		gNOI-5.1: Ping Test
Openconfig Lemming		gNOI-5.1: Ping Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNOI-5.1: Ping Test
Cisco 8808		gNOI-5.1: Ping Test
Juniper PTX10008		gNOI-5.1: Ping Test
Nokia 7250 IXR-10e		gNOI-5.1: Ping Test

Help

[gemini-code-assist]

Code Review

This pull request removes the standard deviation validation from the gNOI ping tests. It deletes the minimumStdDev constant, removes the StdDev field from the expected statistics in multiple test cases, and eliminates the logic for verifying the standard deviation of ping responses. I have no feedback to provide.