Skip to content

DP-1.14: fix potential nil pointer dereference errors #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthikeya-remilla wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Open

DP-1.14: fix potential nil pointer dereference errors #5363

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc85a01
fix potential nil pointer dereference errors
karthikeya-remilla Apr 20, 2026
cde1999
gemini comments
karthikeya-remilla Apr 20, 2026
cc305cf
Merge branch 'main' into karremil/dp-1.14-panic-fix
karthikeya-remilla Apr 27, 2026
d86deda
Merge branch 'main' into karremil/dp-1.14-panic-fix
karthikeya-remilla Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions feature/qos/otg_tests/qos_basic_test/qos_basic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,28 +441,32 @@ func TestBasicConfigWithTraffic(t *testing.T) {
if !deviations.QosGetStatePathUnsupported(dut) {
for _, data := range trafficFlows {
count, ok := gnmi.Watch(t, dut.GNMIOpts().WithYGNMIOpts(opts...), gnmi.OC().Qos().Interface(dp3.Name()).Output().Queue(data.queue).TransmitPkts().State(), timeout, isPresent).Await(t)
if !ok {
t.Errorf("TransmitPkts count for queue %q on interface %q not available within %v", dp3.Name(), data.queue, timeout)
if !ok || count == nil {
t.Errorf("TransmitPkts count for queue %q on interface %q not available within %v", data.queue, dp3.Name(), timeout)
} else {
counters["dutQosPktsBeforeTraffic"][data.queue], _ = count.Val()
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
counters["dutQosPktsBeforeTraffic"][data.queue], _ = count.Val()

count, ok = gnmi.Watch(t, dut.GNMIOpts().WithYGNMIOpts(opts...), gnmi.OC().Qos().Interface(dp3.Name()).Output().Queue(data.queue).TransmitOctets().State(), timeout, isPresent).Await(t)
if !ok {
t.Errorf("TransmitOctets count for queue %q on interface %q not available within %v", dp3.Name(), data.queue, timeout)
if !ok || count == nil {
t.Errorf("TransmitOctets count for queue %q on interface %q not available within %v", data.queue, dp3.Name(), timeout)
} else {
counters["dutQosOctetsBeforeTraffic"][data.queue], _ = count.Val()
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
counters["dutQosOctetsBeforeTraffic"][data.queue], _ = count.Val()

count, ok = gnmi.Watch(t, dut.GNMIOpts().WithYGNMIOpts(opts...), gnmi.OC().Qos().Interface(dp3.Name()).Output().Queue(data.queue).DroppedPkts().State(), timeout, isPresent).Await(t)
if !ok {
t.Errorf("DroppedPkts count for queue %q on interface %q not available within %v", dp3.Name(), data.queue, timeout)
if !ok || count == nil {
t.Errorf("DroppedPkts count for queue %q on interface %q not available within %v", data.queue, dp3.Name(), timeout)
} else {
counters["dutQosDroppedPktsBeforeTraffic"][data.queue], _ = count.Val()
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
counters["dutQosDroppedPktsBeforeTraffic"][data.queue], _ = count.Val()

count, ok = gnmi.Watch(t, dut.GNMIOpts().WithYGNMIOpts(opts...), gnmi.OC().Qos().Interface(dp3.Name()).Output().Queue(data.queue).DroppedOctets().State(), timeout, isPresent).Await(t)
if !ok {
t.Errorf("DroppedOctets count for queue %q on interface %q not available within %v", dp3.Name(), data.queue, timeout)
if !ok || count == nil {
t.Errorf("DroppedOctets count for queue %q on interface %q not available within %v", data.queue, dp3.Name(), timeout)
} else {
counters["dutQosDroppedOctetsBeforeTraffic"][data.queue], _ = count.Val()
}
Comment thread
karthikeya-remilla marked this conversation as resolved.
Outdated
counters["dutQosDroppedOctetsBeforeTraffic"][data.queue], _ = count.Val()
}
}

Expand Down
Loading