SAI API Performance Monitoring#2287
Merged
Merged
Conversation
Signed-off-by: JaiOCP <jai.kumar@broadcom.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@rck-innovium - please help sign off on this |
kcudnik
approved these changes
May 28, 2026
Contributor
Author
|
@rck-innovium Can you please approve this PR or the old closed one (not sure if you can do that) |
rck-innovium
approved these changes
Jun 1, 2026
|
|
||
|
|
||
| ## 4.0 SAI Specification | ||
| New perfmon object is introduced. Each perfmon object specifies the object of interest, set of APIs and metrics to be measured for each API. |
Contributor
There was a problem hiding this comment.
In the current model, SAI_PERFMON_ATTR_COMMON_API is of type sai_common_api_t and SAI_PERFMON_ATTR_PERFMON_METRICS is of type sai_perfmon_metrics_t. Similarly, SAI_PERFMON_ATTR_PERFDATA is a single u64.
These types are NOT lists. Hence, we need to reword that: Each perfmon object specifies the object type of interest, an API type and a metric to be measured.
tjchadaga
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2279 is the original PR. Code base got diverged.
This PR brings in support for measuring SAI API performance. This is based on presentation done in OCP 2023.