fix: preserve generic Linux ffi lock entry - #323
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HAYDEN-OAI
approved these changes
Jul 31, 2026
HAYDEN-OAI
left a comment
Contributor
There was a problem hiding this comment.
Verified that ffi 1.17.2 native variants exclude Ruby >= 3.5, so the generic spec is required for Ruby 4. Existing platforms/native variants and the published gem runtime dependency contract remain unchanged. No substantive issues found.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ffi1.17.2 variant selected by Ruby reportingx86_64-linuxGemfile.lockduring Linux x86_64 installsffivariantRoot cause
The lockfile contained the
x86_64-linux-gnuandx86_64-linux-muslvariants, but Ruby 4.0.6 reportsGem::Platform.localasx86_64-linux. Bundler 4.0.17 selects the generic sourceffivariant for that platform and added the missing spec on every clean checkout.Validation
bundle installandbundle checktwice from a fresh fixed checkout; the lockfile checksum remained unchanged and Git stayed clean after both passesx86_64/linuxgit diff --check