feat(api): allow omitted function-call argument event names - #966
Closed
markstuart-oai wants to merge 1 commit into
Closed
feat(api): allow omitted function-call argument event names#966markstuart-oai wants to merge 1 commit into
markstuart-oai wants to merge 1 commit into
Conversation
Castiron-Internal-PR: openai/openai-java-internal#62 Castiron-Source-SHA: cb386b222ff7aa86293f5e9ac678c20e3851044f Castiron-Public-Base-SHA: d3191b0
Contributor
Castiron custom code✅ No new custom-code files detected. 53 mixed files remain; 0 existing customizations changed; 2 generated baselines changed. Compared
51 existing customizations unchanged
11 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33717084147 --repo openai/openai-java \
--name castiron-custom-code-33717084147-1 --dir /tmp/castiron-custom-code-33717084147-1
git apply --stat /tmp/castiron-custom-code-33717084147-1/custom-code.patch
cat /tmp/castiron-custom-code-33717084147-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin d3191b0db2f456882fd2e2edc3dce126f85505e1 877b691cafd65ea80b06c352221ab1c5bf3e8caf
python3 scripts/castiron/custom_code_report.py report \
--base d3191b0db2f456882fd2e2edc3dce126f85505e1 \
--head 877b691cafd65ea80b06c352221ab1c5bf3e8caf --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-877b691cafd6
cat /tmp/castiron-custom-code-877b691cafd6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
marked this pull request as ready for review
September 3, 2026 04:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Changing name() from String to Optional<String> is a JVM binary break: code compiled against the current SDK looks for name()Ljava/lang/String; and will get NoSuchMethodError after upgrading, even when name is present. Could we preserve the old accessor and add an optional one, or otherwise stage this as a breaking release?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Function-call argument completion events accept an omitted name; the name accessor returns Optional.
Changes