Skip to content

feat(api): recognize incomplete web search call status - #965

Merged
markstuart-oai merged 2 commits into
mainfrom
castiron/promotions/pr-61
Sep 4, 2026
Merged

feat(api): recognize incomplete web search call status#965
markstuart-oai merged 2 commits into
mainfrom
castiron/promotions/pr-61

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Web-search calls recognize incomplete as a known status, including known-value access and validation.

Changes

  • Add incomplete to known stable and beta web-search call statuses.
  • Allow known-value access and validation for this status.

@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Mixed files: 53 → 55

2 newly customized · 0 customizations removed · 0 existing customizations changed · 1 generated baselines changed

Compared fc35f09a64af → b5a632fe561a. Generated baselines verified.

File Result Current custom patch
openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionWebSearch.kt Generated baseline changed +22 / −22
openai-java-core/src/test/kotlin/com/openai/models/beta/responses/BetaResponseFunctionWebSearchTest.kt Newly customized +24 / −0
openai-java-core/src/test/kotlin/com/openai/models/responses/ResponseFunctionWebSearchTest.kt Newly customized +24 / −0
52 existing customizations unchanged
  • openai-java-core/src/main/kotlin/com/openai/models/audio/AudioResponseFormat.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionMessageFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/chat/completions/ChatCompletionToolMessageParam.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/Embedding.kt
  • openai-java-core/src/main/kotlin/com/openai/models/embeddings/EmbeddingCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseCreateParams.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseFunctionToolCall.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseInputItem.kt
  • openai-java-core/src/main/kotlin/com/openai/models/responses/ResponseTextConfig.kt
  • openai-java-core/src/main/kotlin/com/openai/models/videos/Video.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/BetaServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/ResponseServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/WebhookServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsync.kt
  • openai-java-core/src/main/kotlin/com/openai/services/async/finetuning/checkpoints/PermissionServiceAsyncImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/BetaServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/ResponseServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/WebhookServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/audio/TranscriptionServiceImpl.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/chat/ChatCompletionService.kt
  • openai-java-core/src/main/kotlin/com/openai/services/blocking/finetuning/checkpoints/PermissionServiceImpl.kt
  • openai-java-core/src/test/kotlin/com/openai/models/beta/responses/BetaResponsesServerEventTest.kt
  • openai-java-core/src/test/kotlin/com/openai/models/responses/ResponsesServerEventTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/CompletionServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/ImageServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/ResponseServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/WebhookServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/audio/TranscriptionServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/beta/ResponseServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/beta/ThreadServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/beta/threads/RunServiceAsyncTest.kt
  • openai-java-core/src/test/kotlin/com/openai/services/async/chat/ChatCompletionServiceAsyncTest.kt

12 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 33834707417 --repo openai/openai-java \
  --name castiron-custom-code-33834707417-1 --dir /tmp/castiron-custom-code-33834707417-1
git apply --stat /tmp/castiron-custom-code-33834707417-1/custom-code.patch
cat /tmp/castiron-custom-code-33834707417-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin fc35f09a64af08331e7b51ae15891a1af35fc448 b5a632fe561aea53d23406d1a0f2d33a9f97a8c5
python3 scripts/castiron/custom_code_report.py report \
  --base fc35f09a64af08331e7b51ae15891a1af35fc448 \
  --head b5a632fe561aea53d23406d1a0f2d33a9f97a8c5 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-b5a632fe561a
cat /tmp/castiron-custom-code-b5a632fe561a/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 2, 2026 23:31
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 2, 2026 23:31
@openai-sdks

openai-sdks Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 237/237 SDK tests passed in 18.358s for Java SDK PR #965.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 590ms
tests/chat-completions-create.test.ts ✅ Passed 461ms
tests/chat-completions-stream.test.ts ✅ Passed 393ms
tests/files-content-binary.test.ts ✅ Passed 214ms
tests/files-create-multipart.test.ts ✅ Passed 249ms
tests/files-list-pagination.test.ts ✅ Passed 343ms
tests/initialize-config.test.ts ✅ Passed 165ms
tests/instance-isolation.test.ts ✅ Passed 291ms
tests/models-list.test.ts ✅ Passed 174ms
tests/responses-background-lifecycle.test.ts ✅ Passed 286ms
tests/responses-body-method-errors.test.ts ✅ Passed 534ms
tests/responses-cancel-timeout.test.ts ✅ Passed 245ms
tests/responses-cancel.test.ts ✅ Passed 297ms
tests/responses-compact-retries.test.ts ✅ Passed 392ms
tests/responses-compact.test.ts ✅ Passed 384ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 375ms
tests/responses-create-advanced.test.ts ✅ Passed 1.334s
tests/responses-create-disconnect.test.ts ✅ Passed 1.081s
tests/responses-create-errors.test.ts ✅ Passed 355ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 330ms
tests/responses-create-retries.test.ts ✅ Passed 250ms
tests/responses-create-stream-failures.test.ts ✅ Passed 281ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 282ms
tests/responses-create-stream-wire.test.ts ✅ Passed 7.622s
tests/responses-create-stream.test.ts ✅ Passed 376ms
tests/responses-create-terminal-states.test.ts ✅ Passed 395ms
tests/responses-create-timeout.test.ts ✅ Passed 254ms
tests/responses-create.test.ts ✅ Passed 331ms
tests/responses-delete.test.ts ✅ Passed 290ms
tests/responses-input-items-errors.test.ts ✅ Passed 376ms
tests/responses-input-items-list.test.ts ✅ Passed 496ms
tests/responses-input-items-options.test.ts ✅ Passed 550ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 210ms
tests/responses-input-tokens-count.test.ts ✅ Passed 531ms
tests/responses-malformed-inputs.test.ts ✅ Passed 6.708s
tests/responses-not-found-errors.test.ts ✅ Passed 369ms
tests/responses-parse.test.ts ✅ Passed 704ms
tests/responses-retrieve-retries.test.ts ✅ Passed 798ms
tests/responses-retrieve.test.ts ✅ Passed 299ms
tests/responses-stored-method-errors.test.ts ✅ Passed 1.085s
tests/retry-behavior.test.ts ✅ Passed 3.46s
tests/sdk-error-shape.test.ts ✅ Passed 420ms

View OkTest run #33834684611

SDK merge (2476b0d60f0e) · head (b5a632fe561a) · base (fc35f09a64af) · OkTest (2b1bdfd25e98)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T03:52:50.850560Z b5a632f New commits
🔒 Security Review ✅ Completed 2026-09-04T03:52:28.995840Z b5a632f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-61 branch from bd275e1 to e452ec7 Compare September 3, 2026 06:13
@markstuart-oai
feat(api): recognize incomplete web search call status
c2d8605 
Castiron-Internal-PR: openai/openai-java-internal#61
Castiron-Source-SHA: 69b9bfaff97156ed710759a099d200f2c664aefa
Castiron-Public-Base-SHA: 4cd8bf3
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-61 branch from e452ec7 to c2d8605 Compare September 3, 2026 22:36
@markstuart-oai
markstuart-oai added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit bbb465e Sep 4, 2026
13 checks passed
@openai-sdks openai-sdks Bot mentioned this pull request Sep 4, 2026
Merged
lzandman pushed a commit to lzandman/openai-java that referenced this pull request Sep 7, 2026
@openai-sdks
release: 4.58.0 (openai#972)
1992a4a 
Automated Release PR
---


##
[4.58.0](openai/openai-java@v4.57.0...v4.58.0)
(2026-09-04)


### Features

* **api:** recognize incomplete web search call status
([openai#965](openai#965))
([bbb465e](openai@bbb465e))


### Chores

* migrate to forked steady
([openai#971](openai#971))
([fc35f09](openai@fc35f09))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apcha-oai apcha-oai apcha-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markstuart-oai @apcha-oai