Fix Eclipse source attachment for the core JAR - #963
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef8e4654ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ) { | ||
| into("main") | ||
| } | ||
| from(fileTree("src/main/kotlin").matching { include(CoreCompilationClaimedSourceIncludeSpec()) }) |
There was a problem hiding this comment.
When :openai-java-core:kotlinSourcesJar runs, the task's preconfigured source-set copy still emits the unclaimed client/helper sources under main/com/...; this added from only relocates the shard-owned sources that were manually restored after the source-set exclusion. The resulting JAR therefore has a split layout, and the updated verifyCoreCompilationArtifact—which check depends on—reports the remaining main/... entries as unexpected and their root-level counterparts as missing. Reconfigure the task's existing copy spec, or rebuild its contents from the complete source tree, so every source is relocated together.
Useful? React with 👍 / 👎.
1 participant
What
Fix the core sources JAR layout so Kotlin sources are stored at their package paths instead of under a
main/prefix. Update the corresponding artifact verification task to expect the corrected layout.Why
Eclipse cannot automatically attach the published sources because the current JAR layout places sources under
main/com/...rather thancom/....Fixes #447
Tests
git diff --check