fix: guard against empty/filtered LLM responses in make_me_say utils#1666
Open
qizwiz wants to merge 1 commit into
Open
fix: guard against empty/filtered LLM responses in make_me_say utils#1666qizwiz wants to merge 1 commit into
qizwiz wants to merge 1 commit into
Conversation
An empty choices list raises IndexError; a None message raises AttributeError. Add a null check before accessing choices[0].message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a null check in
evals/elsuite/make_me_say/utils.py:get_content()before accessingresponse.choices[0].message.Why
Two silent failure modes crash at this line:
IndexError—choicesis an empty list ([]) when the provider returns no completionsAttributeError—choices[0].messageisNonewhen content is filtered (some providers return HTTP 200 withPROHIBITED_CONTENTfinish reason)Fix
Detected by pact static analysis.