Skip to content

Plumb explicit application paths through Windows launchers - #29845

Closed
jif-oai wants to merge 4 commits into
mainfrom
jif/windows-executable-resolution
Closed

jif-oai wants to merge 4 commits into
mainfrom
jif/windows-executable-resolution

Conversation

@jif-oai

@jif-oai jif-oai commented Jun 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This is the plumbing stage for Windows unified-exec executable resolution. It intentionally does not change how commands are resolved.

  • introduce a WindowsProcessLaunch value that couples argv with an optional resolved executable path
  • carry it through unified exec, elevated runner IPC, and the legacy pipe/ConPTY launch paths
  • preserve existing lookup behavior when no path is supplied; resolver policy, batch handling, environment normalization, and ACL work remain separate follow-ups
  • add IPC round-trip/retry coverage and a Windows integration test for explicit lpApplicationName

Tests

  • just test -p codex-windows-sandbox
  • just test -p codex-cli

@jif-oai
jif-oai force-pushed the jif/windows-executable-resolution branch from 81ec41b to 3d84aba Compare June 24, 2026 19:44
@jif-oai
jif-oai marked this pull request as ready for review June 24, 2026 19:48
@jif-oai
jif-oai requested a review from a team as a code owner June 24, 2026 19:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3d84aba8d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
jif-oai force-pushed the jif/windows-executable-resolution branch from 3d84aba to a8b0373 Compare June 24, 2026 22:22
@jif-oai
jif-oai force-pushed the jif/windows-executable-resolution branch from c77fd06 to 7a52e55 Compare June 25, 2026 10:17
@jif-oai jif-oai changed the title Make Windows executable resolution deterministic Plumb explicit application paths through Windows launchers Jun 25, 2026
@jif-oai

jif-oai commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: d7f40f1465

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai

jif-oai commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

#30036

@github-actions

Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant