Add Intel and Intel Optane Memory attributes/entities - #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR creator: Description
Adds attributes/entities for Intel and Intel Optane Memory.
Intelis currently hardcoded in:intel64:/&intel64;and spelled out verbatim (with literal®/™characters instead of{thrdmrk}) in the SLES 16.0 and 16.1 release notes. This adds a separateintelattribute and composes the Optane names from it, following the existing vendor/product pattern (amd/amdreg,arm/armreg/cortexreg).Both
entities/generic-attributes.adocandentities/generic-entities.entare updated. Rendered output:{intel}{intelreg}{optane}{optanereg}{optanemem}{optanememreg}{nbsp}keeps the vendor and brand together, as in:cortexreg:and:altramax:.:intel64:is left untouched: it is defined in the PLATFORMS section, above the trademark section where:intel:is defined, so it cannot reference{intel}yet. Could do that separately.PR creator: Are there any relevant issues/feature requests?
PR creator: In case of entity changes
If you request an entity change: Please check all doc repositories for
occurrences of this entity (including all supported maintenance branches).
If there are any side-effects that come with the entity change you need to fix
those (after this PR has been accepted and rolled out via doc-kit).
This change is purely additive; no existing entity or attribute changes its value, so there are no side effects in downstream repositories. Once this is rolled out, the literal
Intel® Optane™ Memoryoccurrences in the SLES release notes will be switched to{optanememreg}.PR reviewer: Due diligence
In case of entity changes (product names etc.):