Skip to content

Additional variables from GENeSYS-MOD for openTEPES and Plan4EU#105

Open
tburandt wants to merge 4 commits into
openENTRANCE:mainfrom
tburandt:genesysmod_additions
Open

Additional variables from GENeSYS-MOD for openTEPES and Plan4EU#105
tburandt wants to merge 4 commits into
openENTRANCE:mainfrom
tburandt:genesysmod_additions

Conversation

@tburandt

@tburandt tburandt commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

Additional/changed variables after requests from @erikfilias and @sandrinecharousset

Comment thread nomenclature/definitions/variable/technology/power-plant.yaml

@danielhuppmann danielhuppmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tburandt - see a few comments inline

Comment thread nomenclature/definitions/variable/energy/energy-final.yaml Outdated
Comment thread nomenclature/definitions/variable/technology/power-plant.yaml

@danielhuppmann danielhuppmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tburandt for these changes - I tried to resolve the merge conflicts to save you some time, please review and write a comment when it's good to merge.

One observation: @erikfilias changed the units from GW (only) to allow both MW and GW - maybe also relevant in this PR for consistency?

@danielhuppmann

Copy link
Copy Markdown
Member

@tburandt @loeffko, this PR has not been active for a year - please review whether the proposed changes are still relevant.

If yes, please resolve the merge conflicts or start a new branch and PR with the relevant changes. Then, close this PR.

@sandrinecharousset

Copy link
Copy Markdown
Collaborator

@tburandt @loeffko, this PR has not been active for a year - please review whether the proposed changes are still relevant.

If yes, please resolve the merge conflicts or start a new branch and PR with the relevant changes. Then, close this PR.

@danielhuppmann @loeffko @tburandt it appears that except maybe for the emissions.yaml file, all other changes are already included in the master or in more recent PRs. I would suggest you review the changes in emissions.yaml and create a new PR if necessary, and close this one.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants