Skip to content

Fix jwt.sign expiresInMinutes - #325

Merged
willroberts merged 2 commits into
open-duelyst:mainfrom
eyeq:fix-remove-swear-words
Nov 13, 2026
Merged

willroberts merged 2 commits into
open-duelyst:mainfrom
eyeq:fix-remove-swear-words

Conversation

@eyeq

@eyeq eyeq commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Fix jwt.sign expiresInMinutes

Corrections due to the change from 'expiresInMinutes ' to 'expiresIn'

Testing

Have you have tested your changes in the following scenarios?
Feel free to check off scenarios which don't apply.

  • Starting backend services locally with docker compose up succeeds.
  • I am able to create a new user and log in locally.
  • I am able to complete a practice game locally.
  • I am able to complete a purchase of Orbs, etc.

@willroberts

willroberts commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

I actually think this is not minutes or milliseconds, but seconds. We use jsonwebtoken 5.4.1 whose docs indicate seconds here: https://unpkg.com/jsonwebtoken@5.4.1/README.md

It also supports human-readable strings like 14d or 2w.

@eyeq

eyeq commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Sorry. I was wrong. "Seconds" is correct.
Thank you.

@willroberts
willroberts merged commit 2e930c6 into open-duelyst:main Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants