Skip to content

fix: transpile development TypeScript with Oxc - #159

Merged
l1shen merged 1 commit into
mainfrom
fix/oxc-development-runtime
Oct 26, 2026
Merged

l1shen merged 1 commit into
mainfrom
fix/oxc-development-runtime

Conversation

@l1shen

@l1shen l1shen commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Development and CLI Lab currently execute TypeScript with Node’s strip-only loader, which rejects constructor parameter properties with ERR_UNSUPPORTED_TYPESCRIPT_SYNTAX. Load @oxc-node/core in these entry points so existing TypeScript syntax can run on Node without rewriting application code.

Add the loader explicitly to source-mode isolated executor subprocesses, which run with a restricted environment. Compiled production executors continue to run JavaScript without the loader. Pin Oxc as a development dependency and document the development runtime.

Validation:

  • bun run check passed, including after rebasing onto current main.
  • Isolated runtime tests: 54 passed, including after rebasing.
  • bun run lab test passed before rebasing.
  • Development server startup, source-change restart, and API response after restart passed before rebasing.
  • Server production build passed; compiled isolated executor returned the expected result under Node without a TypeScript loader before rebasing.
  • bun run test:docker was attempted but blocked before project build by a Docker Hub authentication endpoint connection reset. Container validation remains outstanding.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: d9ce8ce6-8496-4cf1-b08f-d2c3807a6655
Commits

Reviewing files that changed from the base of the PR and between 1543497 and 3370dcf.

Files ignored due to path filters: 1
  • bun.lock is excluded by !**/*.lock
Files selected for processing: 5
  • CONTRIBUTING.md
  • apps/server/node/runtime/isolated-vm.ts
  • apps/server/package.json
  • apps/server/scripts/dev.ts
  • package.json

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Summary by CodeRabbit

  • Development
    • TypeScript development code now runs directly on Node.js, including isolated runtime execution. Production continues to use compiled JavaScript, and type checking remains a separate step.
  • Documentation
    • Updated development setup instructions to explain the runtime and type-checking workflow.

Walkthrough

Development Node.js launch commands now preload @oxc-node/core/register. The isolated runtime executor adds the loader when the module path ends in .ts. The contribution guide distinguishes development transpilation from production JavaScript and states that type checking runs separately with bun run check.

Priority: Normal

Merge Risk: Minimal · up to 3370d

The change is mergeable with normal validation; no concrete implementation risk is currently supported.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title uses the required format type: subject, with the optional scope omitted. It clearly describes the TypeScript transpilation fix.
Description check Passed The description directly explains the Oxc loader changes, affected runtimes, production behavior, dependencies, documentation, and validation results.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@l1shen
l1shen merged commit 376a927 into main Oct 26, 2026
7 checks passed
@l1shen
l1shen deleted the fix/oxc-development-runtime branch October 26, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant