Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fixed: update dependency#1231

Merged
zzggo merged 1 commit into
masterfrom
1229-bug0x-prefix-duplicated-in-from-address-when-using-flow-wallet
Aug 1, 2025
Merged

fixed: update dependency#1231
zzggo merged 1 commit into
masterfrom
1229-bug0x-prefix-duplicated-in-from-address-when-using-flow-wallet

Conversation

@zzggo

@zzggo zzggo commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

Closes #1229

Related Issue

Closes #1229

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@github-actions

github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown

PR Summary

Updated the @onflow/frw-core package from version 0.1.1 to 0.1.5 and bumped the extension version from 2.9.1 to 2.9.2. This update was marked as high risk and requires regression testing, suggesting significant changes in the core functionality.

Changes

File Summary
package.json Bumped extension version from 2.9.1 to 2.9.2 and updated @onflow/frw-core dependency from 0.1.1 to 0.1.5
pnpm-lock.yaml Updated dependency lock file to reflect the new package versions

autogenerated by presubmit.ai

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 6a41c42: fixed: update dependency

Closes #1229

Files Processed (2)
  • package.json (2 hunks)
  • pnpm-lock.yaml (0 hunks)
Actionable Comments (1)
  • package.json [56-56]

    possible issue: "Consider updating related dependencies"

Skipped Comments (0)

Comment thread package.json
"@noble/secp256k1": "^1.7.2",
"@onflow/fcl": "^1.19.0",
"@onflow/frw-core": "^0.1.1",
"@onflow/frw-core": "^0.1.5",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @onflow/frw-core package is being updated from 0.1.1 to 0.1.5, but related packages like @onflow/frw-data-model, @onflow/frw-extension-shared, and @onflow/frw-reducers remain at version 0.1.1. Consider checking if these related packages need to be updated as well to maintain compatibility and avoid potential version conflicts.

@zzggo
zzggo requested a review from caosbad August 1, 2025 04:37
@zzggo
zzggo merged commit 9a9b8e3 into master Aug 1, 2025
6 of 7 checks passed
@zzggo
zzggo deleted the 1229-bug0x-prefix-duplicated-in-from-address-when-using-flow-wallet branch August 1, 2025 04:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants