Skip to content

Require the user be a developer to request publishing a resource #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AjBreidenbach wants to merge 1 commit into
base: handover
Choose a base branch
from
Open

Require the user be a developer to request publishing a resource #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/oc-pages/dashboard/components/share-resource-toggle.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default {
},
components: {DetectIcon, GlDropdown, GlDropdownItem, GlDropdownDivider},
computed: {
...mapGetters(['getCurrentEnvironment', 'getDeploymentTemplate', 'getResourceSharedState', 'getHomeProjectPath', 'resolveResourceTypeFromAny']),
...mapGetters(['getCurrentEnvironment', 'getDeploymentTemplate', 'getResourceSharedState', 'getHomeProjectPath', 'resolveResourceTypeFromAny', 'getUser']),
canShareResource() {
/*
* don't require connect implementation, handled by Unfurl
Expand Down Expand Up @@ -47,6 +47,9 @@ export default {
return `Shared in <b>${this.getCurrentEnvironment.name}</b>.`
}
return ''
},
canPublish() {
return this.openCloudPublish && this.getUser?.external === false
}
},
methods: {
Expand Down Expand Up @@ -125,7 +128,7 @@ export default {
<div class="d-inline-flex">Share in current environment</div>
</gl-dropdown-item>
<gl-dropdown-item v-if="sharedStatus != 'dashboard'" @click="shareWithDashboard">Share with all environments</gl-dropdown-item>
<gl-dropdown-item v-if="openCloudPublish" @click="sharePublic">Share publically</gl-dropdown-item>
<gl-dropdown-item v-if="canPublish" @click="sharePublic">Share publically</gl-dropdown-item>
<gl-dropdown-item v-if="sharedStatus" @click="stopSharing">Stop sharing <b>{{card.title}}</b></gl-dropdown-item>
</gl-dropdown>
</template>