Handle many channels

[Nirkan]

[Description of PR]

Please see https://github.com/ome/omero-figure/blob/master/docs/contributing.md
for a testing checklist.

Fixes #624 .

This PR does the following.

• Limits the number of active channels allowed. This can be set with server config setting omero.figure.max_active_channels and user gets a pop up message as can be seen in the image below.
• Only include active channel - The omero.figure seems to only activate first 3 channels. This can also be limited with omero.figure.max_active_channels 2 or 1 if only 1 channel needs to be active.
• UI Layout - There seems to be already a scrollable panel implemented by someone as seen in the image (the left scrollable panel on the right side.)

• Testing : The testing was done with docker-example-omero by adding configuration CONFIG_omero_figure_max__active__channels: 15 to docker-compose.yml file and can be tested at localhost:4080/figure/

[will-moore]

Thanks for the PR.
I'm not sure how it's working for you to do cfg.getConfigValue('omero.figure.max_active_channels') since this is loading config from the server, but AFAIK it only works for settings that are known about on the server. I'm getting a SecurityViolation exception with that code.

Also, this should really be an OMERO.figure setting that's set in the web environment.
As an example, see the comparable setting in iviewer:
https://github.com/ome/omero-iviewer/pull/500/changes

OMERO.figure doesn't have any figure_settings.py yet, as there are not yet any settings for figure. So you'd need to create one similar to the iviewer_settings.py that's modified in that PR.

All the other code is looking good and works fine.

Build above is failing due to flake8 errors:

./omero_figure/views.py:108:80: E501 line too long (80 > 79 characters)
./omero_figure/views.py:137:80: E501 line too long (80 > 79 characters)

[will-moore]

Also, could you add this config option to the README, as a final optional install step, right before "Now restart OMERO.web as normal", e.g:

Optional: To change the maximum active channel count from the default of 10:

$ omero config set omero.figure.max_active_channels 15

[Nirkan]

Thank you for your comments and suggestions.

For me it works in the local docker server and I had to define the configuration in the docker-compose.yml file in the omeroserver: -> environment: -> CONFIG_omero_figure_max__active__channels: 15 below other configurations.
Then composed it using docker compose up -d and this added server configuration permanently in omero-server container.
Used omero-server and postgresql container from docker and web from omero-web running at port 4080.

I agree, this should really be an OMERO.figure setting that's set in the web environment. I tried to add something similar to PR#500 in the settings.py and may be I need to create a separate figure_settings.py as suggested above. I will try to implement this as web setting, following the comments above.

[will-moore]

Looks good, thanks.

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-plugins-push#42. See the console output for more details.
Possible conflicts:

• PR Refresh metadata button to reload channel names, pixel sizes #654 Tom-TBT 'Refresh metadata button to reload channel names, pixel sizes'
  • src/js/models/panel_model.js
• PR Zarr #663 will-moore 'Zarr'
  • src/js/models/panel_model.js

--conflicts Conflict resolved in build OMERO-plugins-push#67. See the console output for more details.