Remove strict jsonchemas and conformance test cases - #140
Closed
clbarnes wants to merge 2 commits into
Closed
Conversation
Automated Review URLs |
Member
|
Sounds fine to remove the strict schemas if they are more trouble than they're worth. It seems that in some cases, e.g. well, multiscales and plate, we don't have any "non-strict" examples, so this PR removes the only examples we have. Are the examples in this repo used ONLY for testing? Are they also useful for docs/ illustration examples too? |
Contributor
I think in these cases the strict/non-strict schemas are identical? |
Contributor
Author
|
Superceded by #176 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #138 .