Skip to content

Integrator#5

Open
pwalczysko wants to merge 6 commits intoome:mainfrom
pwalczysko:integrator
Open

Integrator#5
pwalczysko wants to merge 6 commits intoome:mainfrom
pwalczysko:integrator

Conversation

@pwalczysko
Copy link
Copy Markdown
Member

This PR is on top of #4

the missing fixes on #4 were connected with xxx-integrator-xxx.

The fixes are implemented here as per recommendations of @kbab on ome/ngff#497 (comment), thank you

cc @jburel @will-moore

@pwalczysko pwalczysko mentioned this pull request Apr 13, 2026
@pwalczysko
Copy link
Copy Markdown
Member Author

@jburel Could you have a look please ? I cannot add you as a reviewer on this repo, thank you.

Comment thread Cellpose_parallel.ipynb Outdated
@jburel
Copy link
Copy Markdown
Member

jburel commented Apr 13, 2026

@pwalczysko one of the links is not correct. Suggestion made

Co-authored-by: jean-marie burel <j.burel@dundee.ac.uk>
@pwalczysko
Copy link
Copy Markdown
Member Author

@jburel thanks for catching that, commited the fix

Comment thread Cellpose_parallel.ipynb Outdated
"\n",
"Using ome-zarr for both IDR and BIA allows us to use the same analytical pipeline on data stored in two different resources.\n",
"We will run Cellpose against an [image](https://uk1s3.embassy.ebi.ac.uk/bia-integrator-data/pages/S-BIAD338/804b2976-1111-4099-8bfc-21d1d1d2163c.html) in BIA associated with the study with accession number [S-BIAD338]( https://www.ebi.ac.uk/biostudies/BioImages/studies/S-BIAD338)"
"We will run Cellpose against an [image](https://livingobjects.ebi.ac.uk/bia-integrator-data/pages/S-BIAD338/804b2976-1111-4099-8bfc-21d1d1d2163c.html) in BIA associated with the study with accession number [S-BIAD338]( https://www.ebi.ac.uk/biostudies/BioImages/studies/S-BIAD338)"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

url should be: image (i.e. bia -> bioimaging)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 1329d95

Copy link
Copy Markdown

@kbab kbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one instance of bia-integrator-data that needs to be changed to bioimaging-integrator-data

@pwalczysko
Copy link
Copy Markdown
Member Author

There is one instance of bia-integrator-data that needs to be changed to bioimaging-integrator-data

Thank you @kbab , fixed in 1329d95

@pwalczysko pwalczysko requested review from jburel and kbab April 13, 2026 15:30
Copy link
Copy Markdown

@kbab kbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pwalczysko
Copy link
Copy Markdown
Member Author

@jburel Do you want to merge please ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants