Skip to content

fabtests: Add comment clarifying loop invariant in ft_spin_for_comp #12224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunkuamzn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fabtests: Add comment clarifying loop invariant in ft_spin_for_comp #12224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fabtests/common/shared.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2767,6 +2767,12 @@ static int ft_spin_for_comp(struct fid_cq *cq, uint64_t *cur,
if (timeout >= 0)
clock_gettime(CLOCK_MONOTONIC, &a);

/*
* Callers must ensure *cur < total; calling with *cur >= total
* is a bug because the do...while loop always executes at least
* once and can increment *cur causing an underflow in the
* loop condition.
*/
do {
ret = fi_cq_read(cq, &comp, 1);
if (ret > 0) {
Expand Down
Loading