Skip to content

prov/efa: Refactor AV to split it for efa/efa-direct #12222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-szegel wants to merge 16 commits into
base: main
Choose a base branch
from
+3,830 −2,203
Open

prov/efa: Refactor AV to split it for efa/efa-direct #12222

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
73b570d
prov/efa: add efa_av_is_valid_address helper function
a-szegel Apr 13, 2026
6b89ad2
prov/efa: add efa_proto_av header with struct definitions
a-szegel Apr 9, 2026
12f00c7
prov/efa: add context_len parameter to efa_av_init_util_av
a-szegel May 5, 2026
e66e642
prov/efa: add efa_av_addr_to_entry and efa_av_entry_ep_addr helpers
a-szegel May 5, 2026
bd5b66b
prov/efa: migrate base path callers to efa_av_addr_to_entry
a-szegel May 5, 2026
0eb01d7
prov/efa: change efa_av_reverse_av_add/_remove signature to take efa_…
a-szegel May 5, 2026
c4743cf
prov/efa: add efa_proto_av implementation
a-szegel May 5, 2026
5059ae0
prov/efa: use FI_ADDR_NOTAVAIL for empty fi_addr slot check
a-szegel May 5, 2026
9c35b0c
prov/efa: wire efa_proto_av into RDM, switch peer backing to efa_prot…
a-szegel May 5, 2026
027f6ca
prov/efa: release util_domain.lock on malloc failure in efa_ah_alloc
a-szegel May 6, 2026
65f7055
prov/efa: fix AH layering — move eviction to efa_proto_av.c
a-szegel May 6, 2026
5415fed
prov/efa: split efa_ah into base and protocol layers
a-szegel May 6, 2026
451a3a7
prov/efa: strip efa_av to base-only
a-szegel May 6, 2026
7af9f8a
prov/efa: delete efa_conn.c and efa_conn.h
a-szegel May 6, 2026
2b8e742
prov/efa/test: split AV tests into base and protocol files
a-szegel Apr 10, 2026
3e8d130
prov/efa/test: add new unit tests for AV coverage
a-szegel Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libfabric.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,7 @@
<ClCompile Include="prov\efa\src\efa_av.c" />
<ClCompile Include="prov\efa\src\efa_ah.c" />
<ClCompile Include="prov\efa\src\efa_conn.c" />
<ClCompile Include="prov\efa\src\rdm\efa_proto_av.c" />
<ClCompile Include="prov\efa\src\efa_hmem.c" />
<ClCompile Include="prov\efa\src\efa_device.c" />
<ClCompile Include="prov\efa\src\efa_domain.c" />
Expand Down Expand Up @@ -1019,6 +1020,7 @@
<ClInclude Include="prov\efa\src\efa_av.h" />
<ClInclude Include="prov\efa\src\efa_ah.h" />
<ClInclude Include="prov\efa\src\efa_conn.h" />
<ClInclude Include="prov\efa\src\rdm\efa_proto_av.h" />
<ClInclude Include="prov\efa\src\efa_base_ep.h" />
<ClInclude Include="prov\efa\src\efa_cntr.h" />
<ClInclude Include="prov\efa\src\rdm\efa_rdm_ep.h" />
Expand Down
2 changes: 2 additions & 0 deletions prov/efa/Makefile.include
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ _efa_files = \
prov/efa/src/efa_av.c \
prov/efa/src/efa_ah.c \
prov/efa/src/efa_conn.c \
prov/efa/src/rdm/efa_proto_av.c \
prov/efa/src/efa_domain.c \
prov/efa/src/efa_fabric.c \
prov/efa/src/efa_mr.c \
Expand Down Expand Up @@ -117,6 +118,7 @@ _efa_headers = \
prov/efa/src/efa_data_path_direct_internal.h \
prov/efa/src/efa_mmio.h \
prov/efa/src/rdm/efa_rdm_peer.h \
prov/efa/src/rdm/efa_proto_av.h \
prov/efa/src/rdm/efa_rdm_cq.h \
prov/efa/src/rdm/efa_rdm_cntr.h \
prov/efa/src/rdm/efa_rdm_ep.h \
Expand Down
1 change: 1 addition & 0 deletions prov/efa/src/efa.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include "rdm/efa_rdm_ope.h"
#include "rdm/efa_rdm_pke.h"
#include "rdm/efa_rdm_peer.h"
#include "rdm/efa_proto_av.h"
#include "rdm/efa_rdm_util.h"
#include "fi_ext_efa.h"

Expand Down
10 changes: 5 additions & 5 deletions prov/efa/src/efa_ah.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ void efa_ah_implicit_av_lru_ah_move(struct efa_domain *domain,
}

static inline int efa_ah_implicit_av_evict_ah(struct efa_domain *domain) {
struct efa_conn *conn_to_release;
struct efa_proto_av_entry *entry_to_release;
struct efa_ah *ah_tmp, *ah_to_release = NULL;
struct dlist_entry *tmp;

Expand All @@ -57,13 +57,13 @@ static inline int efa_ah_implicit_av_evict_ah(struct efa_domain *domain) {
assert(ah_to_release->implicit_refcnt > 0);

dlist_foreach_container_safe(&ah_to_release->implicit_conn_list,
struct efa_conn, conn_to_release,
struct efa_proto_av_entry, entry_to_release,
ah_implicit_conn_list_entry, tmp) {

assert(conn_to_release->implicit_fi_addr != FI_ADDR_NOTAVAIL &&
conn_to_release->fi_addr == FI_ADDR_NOTAVAIL);
assert(entry_to_release->implicit_fi_addr != FI_ADDR_NOTAVAIL &&
entry_to_release->fi_addr == FI_ADDR_NOTAVAIL);

efa_conn_release_ah_unsafe(conn_to_release->av, conn_to_release, true);
efa_proto_av_entry_release_ah_unsafe(entry_to_release->av, entry_to_release, true);
}

if (ah_to_release->implicit_refcnt == 0 &&
Expand Down
Loading