Skip to content

[EMTAL] - Server Framework 101 tutorial work - #1392

Open
Emivvvvv wants to merge 18 commits into
odoo:19.0from
odoo-dev:19.0-server-framework-101-emtal
Open

[EMTAL] - Server Framework 101 tutorial work#1392
Emivvvvv wants to merge 18 commits into
odoo:19.0from
odoo-dev:19.0-server-framework-101-emtal

Conversation

@Emivvvvv

Copy link
Copy Markdown

No description provided.

@robodoo

robodoo commented Aug 18, 2026

Copy link
Copy Markdown

Pull request status dashboard

@qucol-odoo qucol-odoo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work :) I highlighted a few stuff that you can have a look at whenever you have the time 👌

Good job also on respecting the commit naming convention 👏 Just FYI, theoretically only the first commit should start with [ADD], as the other ones don't add any new module, they just add features into the existing module (thus they should start with [IMP]). In a more realistic setting, your entire PR could be a singular big [ADD] commit.

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/security/ir.model.access.csv Outdated
Comment thread estate/views/estate_property_tag_views.xml Outdated
Comment thread estate/views/estate_property_views.xml Outdated
Comment thread estate/__manifest__.py Outdated
@Emivvvvv
Emivvvvv force-pushed the 19.0-server-framework-101-emtal branch from f479892 to e5b5572 Compare August 19, 2026 07:49
@Emivvvvv
Emivvvvv requested a review from qucol-odoo August 20, 2026 07:12

@qucol-odoo qucol-odoo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, you really flew through the tutorial with ease 💪 I highlighted a few things worth mentioning, but overall everyone is really good 👌

In a real case scenario, it wouldn't make much sense to have commits fixing issues from other commits belonging to the same PR, because it means that you are introducing an issue and fixing it simultaneously: it would be better to simply not introduce it at all. It would be a great exercise for you to try to get rid of all the [FIX] commits in your PR (hint: you should probably use git rebase -i). Ultimately you could also squash commits to have one per chapter, or even squash everything as one big [ADD] commit, it's kinda up to you, as long as you experiment a bit with the interactive rebasing :)

Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property_offer.py Outdated
Comment thread estate/models/estate_property_offer.py Outdated
Comment thread .gitignore
Comment thread estate_account/security/ir.model.access.csv Outdated
Comment thread estate/views/estate_property_views.xml Outdated
@Emivvvvv
Emivvvvv force-pushed the 19.0-server-framework-101-emtal branch 2 times, most recently from 893bbc4 to 84a0f3c Compare August 21, 2026 09:14
@Emivvvvv
Emivvvvv force-pushed the 19.0-server-framework-101-emtal branch from 84a0f3c to 476b6f7 Compare August 21, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants