[EMTAL] - Server Framework 101 tutorial work - #1392
Conversation
There was a problem hiding this comment.
Thank you for the great work :) I highlighted a few stuff that you can have a look at whenever you have the time 👌
Good job also on respecting the commit naming convention 👏 Just FYI, theoretically only the first commit should start with [ADD], as the other ones don't add any new module, they just add features into the existing module (thus they should start with [IMP]). In a more realistic setting, your entire PR could be a singular big [ADD] commit.
f479892 to
e5b5572
Compare
qucol-odoo
left a comment
There was a problem hiding this comment.
Good job, you really flew through the tutorial with ease 💪 I highlighted a few things worth mentioning, but overall everyone is really good 👌
In a real case scenario, it wouldn't make much sense to have commits fixing issues from other commits belonging to the same PR, because it means that you are introducing an issue and fixing it simultaneously: it would be better to simply not introduce it at all. It would be a great exercise for you to try to get rid of all the [FIX] commits in your PR (hint: you should probably use git rebase -i). Ultimately you could also squash commits to have one per chapter, or even squash everything as one big [ADD] commit, it's kinda up to you, as long as you experiment a bit with the interactive rebasing :)
893bbc4 to
84a0f3c
Compare
84a0f3c to
476b6f7
Compare

No description provided.