vibel - Technical Training - #1384
Conversation
|
|
…better comprehension.
…nce field attributes.
| <menuitem id="estate_menu_properties_action" action="estate_properties_action"/> | ||
| </menuitem> | ||
| </menuitem> | ||
| </odoo> No newline at end of file |
There was a problem hiding this comment.
I think you already noticed and you changed it yourself multiple times. We have to add an empty line always in the end of each file
There was a problem hiding this comment.
Yes, I always forget it, I'll fix it asap!
| <field name="view_mode">list,form</field> | ||
| </record> | ||
| </data> | ||
| </odoo> No newline at end of file |
… estate property model
…e section (form view)
… and include in form
… and include in form
…ffers model and views (list and form).
…flag/unflag garden field in the estate property form view
…rm view in order to set its status.
…o other offers were already accepted
…ccept button of offers).
…s of property models
…ttached properties
yoba-odoo
left a comment
yoba-odoo
left a comment
There was a problem hiding this comment.
Neat work 💯
Just a few comments for enhancements
|
|
||
| # offers should be higher than the ones we already have | ||
| current_prices = estate_property.property_offer_ids.mapped('price') | ||
| if current_prices and float_compare(val['price'], min(current_prices), precision_digits=2) < 0: |
There was a problem hiding this comment.
you don't have to check for the minimum offer through min() you can use estate_property.property_offer_ids[-1] since you are already ordering the offers by price
here https://github.com/odoo/tutorials/pull/1384/changes#diff-8000c23a2907f34f0cc387be9dc4178411fda81b674724854bd4d048f9e11b16R12 so the offers are already sorted
| access_estate_property,estate.property access,model_estate_property,base.group_user,1,1,1,1 | ||
| access_estate_property_type,estate.property.type access,model_estate_property_type,base.group_user,1,1,1,1 | ||
| access_estate_property_tag,estate.property.tag access,model_estate_property_tag,base.group_user,1,1,1,1 | ||
| access_estate_property_offer,estate.property.offer access,model_estate_property_offer,base.group_user,1,1,1,1 No newline at end of file |
| 'views/estate_property_tag_views.xml', | ||
| 'views/res_users_views.xml', | ||
| 'views/estate_menus.xml', | ||
| 'security/ir.model.access.csv' |
There was a problem hiding this comment.
this normally should come first in this list as security is the most important to be loaded first to apply it to the view while installing the module
3 participants
No description provided.