Preserve Git-backed local package pins#1116
Merged
Merged
Conversation
smorimoto
marked this pull request as ready for review
July 20, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
The batched normalised pin format converted every local package directory to an explicit
file://URL. opam interprets explicit file URLs as rsync sources, bypassing its local version-control detection.This could break workflows which use
opam sourceto copy a pinned package into a directory within the source checkout, as the rsync backend rejects overlapping source and destination paths. Using the standard local-path form restores opam's existing Git and rsync inference.Verification
yarn buildyarn lintyarn typecheckgit diff --checkFixes #1114