Skip to content

Quick fix for uncaught 409 on slug conflict. #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Fil wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Quick fix for uncaught 409 on slug conflict. #1381

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38eb777
Quick fix for uncaught 409 on slug conflict.
Fil May 22, 2024
905edc9
Merge branch 'main' into fil/409
Fil Nov 11, 2024
8c58dea
fix merge
Fil Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,12 @@ export async function deploy(
);
} else {
clack.log.error(
wrapAnsi(`Could not create project: ${error instanceof Error ? error.message : error}`, effects.outputColumns)
wrapAnsi(
`Could not create project: ${
(error as any)?.statusCode === 409 ? "conflicting slug." : error instanceof Error ? error.message : error
Copy link
Copy Markdown
Contributor

@mythmon mythmon May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type safe version of this would be something like

if (isErrorMessage(error) && error.statusCode === 409 ...

This is probably fine as is.

}`,
effects.outputColumns
)
);
}
clack.outro(yellow("Deploy canceled"));
Expand Down