Simulation interfaces - part of review suggestions applied#889
Merged
michalpelka merged 5 commits intoo3de:feature/simulation_interfacesfrom Apr 16, 2025
Conversation
Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
…ses, based on @PawelLiberadzki and @michalpelka comments Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
Signed-off-by: Norbert Prokopiuk <norbert.prokopiuk@robotec.ai>
norbertprokopiuk
force-pushed
the
nprokopiuk/simulation_interfaces_review_changes
branch
from
85e5b27 to
693128d
Compare
michalpelka
approved these changes
Apr 16, 2025
michalpelka
merged commit f1fbcc8
into
o3de:feature/simulation_interfaces
1 check passed
jhanca-robotecai
deleted the
nprokopiuk/simulation_interfaces_review_changes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves part of the suggestions left in the PR #874 merging simulation_interfaces to development
How was this PR tested?
I ran built-in tests