Added CMAKE logic to disable Contact Sensor and Spawner components.#842
Merged
michalpelka merged 3 commits intoo3de:feature/simulation_interfacesfrom Mar 21, 2025
Merged
Conversation
Components will be disabled when gazebo_msgs is no longer available. Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
pijaro
requested changes
Mar 20, 2025
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
pijaro
approved these changes
Mar 21, 2025
jhanca-robotecai
approved these changes
Mar 21, 2025
Collaborator
jhanca-robotecai
left a comment
jhanca-robotecai
left a comment
There was a problem hiding this comment.
Nitpick comments about the text.
The implementation is fine, It works when building the project from scratch - in my case, it did not recognize the change when I tried to test it in the following order:
- build the project (gazebo_msgs available)
- remove gazego_msgs
- rebuild the project
This might be considered a corner-case.
Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
merged commit 01f0198
into
o3de:feature/simulation_interfaces
1 check passed
jhanca-robotecai
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Jun 13, 2025
…3de#842) Components will be disabled when gazebo_msgs is no longer available. Apply suggestions from code review --------- Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Components will be disabled when gazebo_msgs is no longer available.
What does this PR do?
This PR will disable compilation of the Contact Sensor and ROS 2 Spawner if gazebo_msgs package is not available.
As is discussed in RFC 95 and ros-simulation/gazebo_ros_pkgs#1532 and https://community.gazebosim.org/t/gazebo-classic-end-of-life/2563 said package is non-longer maintained.
To enable smooth transition, dependant code is disabled. To enable this code, advanced user needs to build gazebo_msgs from released last source.
How was this PR tested?
I simply removed ros-humble-gazebo-msgs package using Synaptic.
ros-humble-gazebo-msgsinstalledros-humble-gazebo-msgsinstalled