Feature/ios-integration#1
Open
AnasMostefaoui wants to merge 13 commits into
Open
Conversation
AnasMostefaoui
force-pushed
the
feature/ios-integration
branch
from
785fa1d to
4a4dc8f
Compare
AnasMostefaoui
commented
Mar 19, 2023
smellouk
reviewed
Mar 19, 2023
smellouk
left a comment
smellouk
left a comment
Collaborator
There was a problem hiding this comment.
Please run detekt on your machine and fix the reported issues
FinalNewline - [File must end with a newline (\n)] at /home/runner/work/sdk-kmp/sdk-kmp/sdk.core/src/iosMain/kotlin/io/nyris/sdk/internal/util/IOSLogger.kt:1:1
FinalNewline - [File must end with a newline (\n)] at /home/runner/work/sdk-kmp/sdk-kmp/sdk.core/src/iosMain/kotlin/io/nyris/sdk/Nyris.kt:1:1
smellouk
reviewed
Mar 19, 2023
| class IntegrationWithKMP { | ||
| func greetings() -> Nyris { | ||
| let config = NyrisConfig(isDebug: true, baseUrl: "", httpEngine: nil, timeout: 10, platform: NyrisPlatform.ios) | ||
| return NyrisCompanion() |
Collaborator
There was a problem hiding this comment.
we could use @ObjCName(swiftName = "Nyris") to rename that from NyrisCompanion to Nyris
Collaborator
Author
There was a problem hiding this comment.
It still doesn't solve the problem, as I need to pass a configuration object with all it's params making the actual implementation in kotlin iOS redundant.
AnasMostefaoui
force-pushed
the
feature/ios-integration
branch
from
2e72955 to
3ee92e1
Compare
smellouk
requested changes
Mar 25, 2023
smellouk
left a comment
smellouk
left a comment
Collaborator
There was a problem hiding this comment.
I just noticed that spotless changes are missing, can we consider to add them please
smellouk
previously approved these changes
Apr 2, 2023
smellouk
force-pushed
the
main
branch
14 times, most recently
from
57448e5 to
ee75107
Compare
- Fix linting issues.
smellouk
force-pushed
the
feature/ios-integration
branch
4 times, most recently
from
9b1cbca to
274739e
Compare
smellouk
force-pushed
the
feature/ios-integration
branch
2 times, most recently
from
721d2a5 to
89d7c94
Compare
smellouk
force-pushed
the
feature/ios-integration
branch
from
89d7c94 to
f9f4bb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add iOS to the KMP project