Skip to content

fix: announce all content inside role="alert" #20056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mehm8128 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: announce all content inside role="alert" #20056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151e9e4
fix: announce all content inside `role="alert"`
mehm8128 May 5, 2026
fa7ba9a
fix: pass proper child name and role to braille.handler.message
mehm8128 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions source/NVDAObjects/IAccessible/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,9 +2036,8 @@ def event_alert(self) -> None:
speech.speakObject(self, reason=controlTypes.OutputReason.FOCUS, priority=speech.Spri.NOW)
braille.handler.message(braille.getPropertiesBraille(name=self.name, role=self.role))
for child in self.recursiveDescendants:
if controlTypes.State.FOCUSABLE in child.states:
Copy link
Copy Markdown
Member

@seanbudd seanbudd May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still should be doing some form of filtering here, right?
what other conditions can we change to fix #14990 and #17862 without being so broad?

speech.speakObject(child, reason=controlTypes.OutputReason.FOCUS, priority=speech.Spri.NOW)
braille.handler.message(braille.getPropertiesBraille(name=self.name, role=self.role))
speech.speakObject(child, reason=controlTypes.OutputReason.FOCUS, priority=speech.Spri.NOW)
braille.handler.message(braille.getPropertiesBraille(name=child.name, role=child.role))

def event_caret(self):
focus = api.getFocusObject()
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ It currently includes Screen Curtain's settings (previously in the "Vision" cate
* In the Input Gestures dialog, gestures including an operator while Num Lock is on will now be correctly displayed. (#19214, @CyrilleB79)
* In Chromium browsers, if a document contains links with a malformed URL, reading the document will be possible again. (#19125, @nvdaes)
* NVDA no longer plays a sound for spelling errors while typing if speech mode is set to on-demand or off. (#19323, @CyrilleB79)
* NVDA now announces all content inside `role="alert"` elements. (#14990, @mehm8128)

### Changes for Developers

Expand Down
Loading