Skip to content

Move markdown lint disabling instruction below 2026.2 change log#19357

Merged
seanbudd merged 3 commits intonvaccess:masterfrom
CyrilleB79:chgLog2026.2
Dec 16, 2025
Merged

Move markdown lint disabling instruction below 2026.2 change log#19357
seanbudd merged 3 commits intonvaccess:masterfrom
CyrilleB79:chgLog2026.2

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

@CyrilleB79 CyrilleB79 commented Dec 9, 2025

Link to issue number:

Fix-up of #19354

Summary of the issue:

In the PR to start 2026.2 dev cycle, the new 2026.2 section has been created, but the markdown disable instruction has remained below 2026.1 section.

Description of user facing changes:

None

Description of developer facing changes:

Moved the instruction to disable markdown linting below 2026.2 section.

Description of development approach:

N/A

Testing strategy:

Not tested. A careful review should be enough.

Known issues with pull request:

None

Additional remark

It seems that internally at NV Access, you have a task list that you copy / paste in the initial description of each PR starting a new dev cycle. It would be the opportunity to update also this task list to mention that the linter command should be moved below the newly created section.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner December 9, 2025 10:10
@seanbudd
Copy link
Copy Markdown
Member

I don't understand why this should be moved? everything under 2026.1 has invalid syntax we don't want to change to avoid translator work. We want to keep everything above that with the correct syntax.

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

I had probably not thought to it so much, but it seemed strange to me that during 2026.2 dev cycle, we still lint 2026.1 change log.

You may object that there won't be any change since 2026.1 is already linted. That's true as long as you don't change linter version. If you upgrade the linter, you may theoritically catch and fix new issues that would not have been caught with the previous linter version.

Maybe we should just change this directive's position when we actually upgrade the linter?

Feel free to close this PR if you feel it is not relevant.

@SaschaCowley
Copy link
Copy Markdown
Member

I think that we should keep linting until the translation freeze. So the disable instruction should stay where it is currently for now, but we should move it above 2026.1 for the last planned beta, or when branching for 2026.3 (the latter is probably easier)

@seanbudd
Copy link
Copy Markdown
Member

I think the easiest would just be to leave it though? I guess the only downside is if linting rules change we would need to move it up

@SaschaCowley
Copy link
Copy Markdown
Member

We could just add a new <!-- markdownlint-disable --> when a version hits stable. I doubt there's a real performance penalty to having multiple of them in one file. I don't like the idea of just trusting that we'll remember to do it if/when lint rules change

@seanbudd
Copy link
Copy Markdown
Member

We'd be forced to do it when lint rules change, for example with #19311. When updating markdownlint we'd either have to lint the old changes, which we wouldn't do out of habit, or move the comment

@SaschaCowley
Copy link
Copy Markdown
Member

We'd be forced to do it when lint rules change, for example with #19311. When updating markdownlint we'd either have to lint the old changes, which we wouldn't do out of habit, or move the comment

That relies on us remembering to do so when we update Markdownlint. It seems safer to me to add a step to the release process to add a comment to the changes file when each section is frozen

@seanbudd
Copy link
Copy Markdown
Member

It wouldn't be a matter of remembering, tests wouldn't pass. You'd be fixing the tests by moving the line

@SaschaCowley
Copy link
Copy Markdown
Member

It wouldn't be a matter of remembering, tests wouldn't pass. You'd be fixing the tests by moving the line

Markdownlint fixes violations that it can fix safely. So when it's run as part of pre-commit.ci, it might modify sections that should be frozen

@seanbudd
Copy link
Copy Markdown
Member

Ah fair enough, I'm convinced to move it each release

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 16, 2025
Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79, I've opened a PR to fix up our template, and also consider moving it here to open source it

@seanbudd seanbudd merged commit ee365d5 into nvaccess:master Dec 16, 2025
41 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Dec 16, 2025
@CyrilleB79 CyrilleB79 deleted the chgLog2026.2 branch December 16, 2025 07:02
Somsubhra-Nandi pushed a commit to Somsubhra-Nandi/nvda that referenced this pull request Jan 9, 2026
…ccess#19357)

Fix-up of nvaccess#19354
Summary of the issue:

In the PR to start 2026.2 dev cycle, the new 2026.2 section has been created, but the markdown disable instruction has remained below 2026.1 section.
Description of user facing changes:

None
Description of developer facing changes:

Moved the instruction to disable markdown linting below 2026.2 section.
tareh7z pushed a commit to tareh7z/nvda that referenced this pull request Feb 16, 2026
…ccess#19357)

Fix-up of nvaccess#19354
Summary of the issue:

In the PR to start 2026.2 dev cycle, the new 2026.2 section has been created, but the markdown disable instruction has remained below 2026.1 section.
Description of user facing changes:

None
Description of developer facing changes:

Moved the instruction to disable markdown linting below 2026.2 section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants