Skip to content

fix issue #1361#1362

Open
wendal wants to merge 1 commit into
masterfrom
issue_1361
Open

fix issue #1361#1362
wendal wants to merge 1 commit into
masterfrom
issue_1361

Conversation

@wendal

@wendal wendal commented Dec 1, 2017

Copy link
Copy Markdown
Member

No description provided.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1362 into master will decrease coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1362      +/-   ##
==========================================
- Coverage   47.42%   47.38%   -0.05%     
==========================================
  Files         810      810              
  Lines       34697    34703       +6     
  Branches     7511     7512       +1     
==========================================
- Hits        16456    16444      -12     
- Misses      16071    16088      +17     
- Partials     2170     2171       +1
Impacted Files Coverage Δ
src/org/nutz/ioc/impl/PropertiesProxy.java 35.21% <100%> (ø) ⬆️
src/org/nutz/lang/util/MultiLineProperties.java 56% <87.5%> (+0.68%) ⬆️
src/org/nutz/mvc/view/HttpServerResponse.java 18.47% <0%> (-9.79%) ⬇️
src/org/nutz/mvc/impl/NutActionChain.java 60.6% <0%> (-6.07%) ⬇️
src/org/nutz/mvc/view/HttpStatusView.java 28.94% <0%> (-5.27%) ⬇️
src/org/nutz/lang/Streams.java 48.96% <0%> (-1.04%) ⬇️
src/org/nutz/mvc/WhaleFilter.java 27.35% <0%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcf5199...3102f13. Read the comment docs.

@wendal wendal requested a review from ywjno December 1, 2017 03:08
@happyday517

Copy link
Copy Markdown
Contributor

加一个行为开关会不会更好一些?
默认是key,value左右都trim的
开关切换后,和jdk自带的properties行为一致

@happyday517

Copy link
Copy Markdown
Contributor

不过话说,jdk自带的properties行为也像是一种疏忽
我还是倾向于全部trim了 ^_^

@wendal

wendal commented Jan 5, 2018

Copy link
Copy Markdown
Member Author

-_- 还没决定,不知道如何是好...

@qinerg

qinerg commented Nov 11, 2019

Copy link
Copy Markdown
Member

PropertiesProxy 加一个构造方法,填加一个开关参数,默认为关,当打开时启动 trim。各取所需,呵呵。

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants