Adapter issue1418#1186
Open
OsirisTerje wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates documentation to reflect new/updated NUnit features: it documents a new VS Test Adapter .runsettings option for DefaultMaxTime, and it adds an initial NUnit 5.0.0-beta.1 section to the framework release notes.
Changes:
- Document
DefaultMaxTimein the VS Test Adapter tips/tricks, including a new details section and version note. - Add an NUnit 5.0.0-beta.1 (“TBD”) release notes entry with enhancements, bug fixes, breaking changes, and acknowledgements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/articles/vs-test-adapter/Tips-And-Tricks.md | Adds documentation for the new DefaultMaxTime adapter runsettings option and its behavior/version. |
| docs/articles/nunit/release-notes/framework.md | Introduces NUnit 5.0.0-beta.1 release notes content at the top of the framework release notes page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| > [!IMPORTANT] | ||
| > This issue is a breaking change. | ||
| > | ||
| > The following assertions now return a `Task` which much be awaited in order for the assertion to be evaluated. |
Comment on lines
+33
to
+35
| * [5273](https://github.com/nunit/nunit/issues/5273) Verify that generic AssignableToConstraint and AssignableFromConstraint works as expected. Thanks to NUnit Team member [Steven Weerdenburg](https://github.com/stevenaw) for [PR 5277](https://github.com/nunit/nunit/pull/5277) | ||
| * [5222](https://github.com/nunit/nunit/issues/5222) AssemblyVersion. | ||
| * [5180](https://github.com/nunit/nunit/issues/5180) Change namespace for legacy String-, Collection-, File- and DirectoryAssert classes. Thanks to NUnit Team member [Terje Sandstrom](https://github.com/OsirisTerje) for [PR 5181](https://github.com/nunit/nunit/pull/5181) |
Comment on lines
+39
to
+42
| * [5301](https://github.com/nunit/nunit/issues/5301) Update README and nuspec files for NUnit 5. Thanks to NUnit Team member [Terje Sandstrom](https://github.com/OsirisTerje) for [PR 5302](https://github.com/nunit/nunit/pull/5302) | ||
| * [5228](https://github.com/nunit/nunit/issues/5228) Set assembly version to Minver default for the 5.0.0.0 release. Thanks to NUnit Team member [Terje Sandstrom](https://github.com/OsirisTerje) for [PR 5299](https://github.com/nunit/nunit/pull/5299) | ||
| * [5222](https://github.com/nunit/nunit/issues/5222) AssemblyVersion. | ||
| * [5197](https://github.com/nunit/nunit/issues/5197) Add files to support AI agent coding. Thanks to [Joel Dickson](https://github.com/joeldickson) for [PR 5225](https://github.com/nunit/nunit/pull/5225) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.