Skip to content

chore(hire): set the author pages' italic in lora - #863

Merged
nrjdalal merged 1 commit into
canaryfrom
feat/hire-italic-lora
Oct 4, 2026
Merged

nrjdalal merged 1 commit into
canaryfrom
feat/hire-italic-lora

Conversation

@nrjdalal

Copy link
Copy Markdown
Owner

Summary

Swaps the serif italic on /hire and /resume from Newsreader to Lora. Newsreader's small x-height made the inline italic spans read a size smaller than the DM Sans body around them. Lora's matches, so they sit level with the text.

A side-by-side of the page copy in Newsreader and six candidates picked Lora.

Changes

  • Fonts module: lora replaces newsreader in web/next/src/lib/marketing/fonts.ts. Every use is italic, so only Lora's italic file is vendored. It is declared with style: "italic", or the face registers as upright and the italic class slants it a second time. It also sets the Times New Roman fallback metrics the fonts skill asks of a serif.
  • Pages: both pages import lora; class names are otherwise unchanged.
  • Files: both Newsreader woff2 files are removed. The two pages' marketing preload drops from about 193KB to 116KB.
  • Docs and skills: the theming page names Lora and --font-lora. The fonts skill gains a note on the italic-only setup.

Verification

  • Lint, format, and type checks pass locally.
  • In a real browser on the worktree's dev stack: the Lora face registers as italic at 400 to 700 and loads, the spans compute to it, and its preload appears on /hire but not on /. No font 404s in the dev log. No horizontal overflow at 390px.
  • Before (production) and after screenshots at 1782x972, light and dark, plus phone width, are in the comment below.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VBYxUtQGsiCZ57FgqffMu3

Newsreader read small beside DM Sans on /hire and /resume. Lora's x-height
matches the body, so the inline spans sit level with the text around them.

Every use is italic, so only Lora's italic file is vendored, declared with
style "italic" so the class does not slant it a second time, and with the
Times New Roman fallback metrics the fonts skill asks of a serif. Both
Newsreader files go, which drops the pages' font preload from about 193KB to
116KB. The theming doc names the new face and the fonts skill notes the
italic-only setup.

Claude-Session: https://claude.ai/code/session_01VBYxUtQGsiCZ57FgqffMu3
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api.zerostarter.dev Ready Ready Preview Sep 29, 2026 10:38pm UTC
zerostarter.dev Ready Ready Preview Sep 29, 2026 10:38pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: nrjdalal/zerostarter/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8075a96d-c106-4081-811b-d1e3016e941e

📥 Commits

Reviewing files that changed from the base of the PR and between 847cfd7 and 71d3571.

⛔ Files ignored due to path filters (4)
  • .agents/skills/fonts/SKILL.md is excluded by !**/.agents/**
  • web/next/src/fonts/marketing/lora-latin-wght-italic.woff2 is excluded by !**/*.woff2
  • web/next/src/fonts/marketing/newsreader-latin-wght-italic.woff2 is excluded by !**/*.woff2
  • web/next/src/fonts/marketing/newsreader-latin-wght-normal.woff2 is excluded by !**/*.woff2
📒 Files selected for processing (4)
  • web/next/content/docs/manage/theming.mdx
  • web/next/src/app/(marketing)/hire/page.tsx
  • web/next/src/app/(marketing)/resume/page.tsx
  • web/next/src/lib/marketing/fonts.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nrjdalal

Copy link
Copy Markdown
Owner Author

Browser evidence

Before is production (zerostarter.dev), after is this branch's dev stack, both at 1782x972.

/hire, top, light

Before: hire top in Newsreader
After: hire top in Lora

/hire, "hire me" quote, dark

Before: hire quote in Newsreader, dark
After: hire quote in Lora, dark

/resume, top, light

Before: resume top in Newsreader
After: resume top in Lora

/hire at 390x844 (after)

After: hire quote in Lora at phone width

@github-actions github-actions Bot added @.agents Auto-created label for @.agents @web/next Auto-created label for @web/next 0/1 PR has 0 of 1 required approvals labels Sep 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Important

Merge with a squash commit (not merge), so canary stays one commit per PR and shared-history merges stay reserved for release PRs. Delete the branch after merging to keep the remote clean.

@nrjdalal
nrjdalal merged commit 260a5e6 into canary Oct 4, 2026
7 checks passed
@nrjdalal
nrjdalal deleted the feat/hire-italic-lora branch October 4, 2026 14:59

This branch was successfully deployed

2 active deployments
Preview – api.zerostarter.dev — 71d3571e Deployed Sep 29, 2026 by vercel[bot]
Preview – zerostarter.dev — 71d3571e Deployed Sep 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0/1 PR has 0 of 1 required approvals @.agents Auto-created label for @.agents @web/next Auto-created label for @web/next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant