perf: skip construction for unchanged stuff#905
Open
JohnTitor wants to merge 1 commit intonotify-rs:mainfrom
Open
perf: skip construction for unchanged stuff#905JohnTitor wants to merge 1 commit intonotify-rs:mainfrom
JohnTitor wants to merge 1 commit intonotify-rs:mainfrom
Conversation
JohnTitor
commented
Apr 24, 2026
| event_kind | ||
| } else { | ||
| let event_kind = PathData::compare_to_kind(None, Some(&new_path_data)); | ||
| self.all_path_data.insert(path.clone(), new_path_data); |
Member
Author
There was a problem hiding this comment.
The main win comes from not calling this clone unconditionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize
PollWatcherrescans by deferring reported-path construction until an event is actually emitted.The rescan loop now compares the existing and new
PathDatafirst, updates stored data in place for existing paths, and only builds the reportedEventpath whencompare_to_kindreturns an actual event kind.On my end, it's roughly a 25% improvement for the measured no-op recursive polling workload.
Related Issues