Skip to content

Fix lost MouseButtonUp events when releasing mouse outside window (Linux/X11) #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheRedDeveloper wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix lost MouseButtonUp events when releasing mouse outside window (Linux/X11) #1018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ struct Context {
quit_requested: bool,

cursor_grabbed: bool,
previous_cursor_grabbed: bool,

input_events: Vec<Vec<MiniquadInputEvent>>,

Expand Down Expand Up @@ -339,6 +340,7 @@ impl Context {
quit_requested: false,

cursor_grabbed: false,
previous_cursor_grabbed: false,

input_events: Vec::new(),

Expand Down Expand Up @@ -705,8 +707,13 @@ impl EventHandler for Stage {
fn update(&mut self) {
let _z = telemetry::ZoneGuard::new("Event::update");

// Unless called every frame, cursor will not remain grabbed
miniquad::window::set_cursor_grab(get_context().cursor_grabbed);
// Keep the cursor grabbed by calling every frame.
// But only ungrab once to preserve implicit mouse grabs.
let context = get_context();
if context.cursor_grabbed || context.cursor_grabbed != context.previous_cursor_grabbed {
miniquad::window::set_cursor_grab(context.cursor_grabbed);
}
context.previous_cursor_grabbed = context.cursor_grabbed;

#[cfg(not(target_arch = "wasm32"))]
{
Expand Down