Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/conditionals-and-loops/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import { CivComponent, Reactive, Template, css, html } from 'civ-fe';
<button @click="list.pop()">Pop Number</button>
<button @click="list.reverse()">Reverse List</button>

<ul v-if="show && list.length">
<li v-for="item of list">{{ item }}</li>
<ul *if="show && list.length">
<li *for="item of list">{{ item }}</li>
</ul>
<p v-else-if="list.length">List is not empty, but hidden.</p>
<p v-else>List is empty.</p>
<p *else-if="list.length">List is not empty, but hidden.</p>
<p *else>List is empty.</p>
</div>
`)
export default class ConditionalsAndLoops extends CivComponent {
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-component/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class TodoItem extends CivComponent {
@ResolveComponents({ TodoItem })
@Template(html`
<ol>
<TodoItem v-for="item of groceryList" prop:todo="item" />
<TodoItem *for="item of groceryList" prop:todo="item" />
</ol>
`)
export default class SimpleComponent extends CivComponent {
Expand Down
29 changes: 27 additions & 2 deletions src/civ-component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { INJECTED_NS_PREFIX, REACTIVE_TEMPLATE_DOM, REACTIVE_TEMPLATE_SHEET, Rea
import { activateReactivity, initReactivity, REACTIVE_KIT, ReactivityHost } from "./lib/reactive";
import {
attachedEventName, detachEventName, moveEventName, movedEventName,
attrToTrait, componentFlagClass, isMagicForAttr, isMagicForTemplateElement,
attrToTrait, componentFlagClass, isMagicElifAttr, isMagicElseAttr, isMagicForAttr, isMagicForTemplateElement, isMagicIfAttr,
significantFlagClass, subtreeTemplateFlagClass,
Traits, EventHandlerTrait,
} from "./protocol";
Expand Down Expand Up @@ -420,6 +420,7 @@ export class CivComponent extends EventTarget {
}
const elemTraits: Traits = [];
const magicAttrs: Attr[] = [];
const structuralTraitAttrMap = new Map<'for' | 'if' | 'elif' | 'else', string>();
if (Reflect.get(components, elem.tagName.toUpperCase())) {
elem.classList.add(componentFlagClass);
}
Expand All @@ -433,7 +434,31 @@ export class CivComponent extends EventTarget {
if (!trait) {
continue;
}
elemTraits.push(trait);
const structuralTrait = isMagicForAttr(name) ? 'for' :
isMagicIfAttr(name) ? 'if' :
isMagicElifAttr(name) ? 'elif' :
isMagicElseAttr(name) ? 'else' :
undefined;
if (structuralTrait) {
const existingTraitIndex = elemTraits.findIndex(([t]) => t === structuralTrait);
if (existingTraitIndex !== -1) {
const existingAttrName = structuralTraitAttrMap.get(structuralTrait) || '';
const existingIsStarAlias = existingAttrName.startsWith('*');
const currentIsStarAlias = name.startsWith('*');
if (!existingIsStarAlias && currentIsStarAlias) {
elemTraits[existingTraitIndex] = trait;
structuralTraitAttrMap.set(structuralTrait, name);
} else {
magicAttrs.push(attr);
continue;
}
} else {
elemTraits.push(trait);
structuralTraitAttrMap.set(structuralTrait, name);
}
} else {
elemTraits.push(trait);
}
magicAttrs.push(attr);
if (trait.length === 1 || !trait.includes(expr)) {
continue;
Expand Down
13 changes: 8 additions & 5 deletions src/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,16 @@ export function isMagicModel(name: string) {
return name === `${pseudoNamespacePrefix}model` || name === 'v-model';
}
export function isMagicForAttr(name: string) {
return name === `${pseudoNamespacePrefix}for` || name === `render:for` || name === 'v-for';
return name === `${pseudoNamespacePrefix}for` || name === `render:for` || name === 'v-for' || name === '*for';
}
export function isMagicIfAttr(name: string) {
return name === `${pseudoNamespacePrefix}if` || name === `render:if` || name === 'v-if';
return name === `${pseudoNamespacePrefix}if` || name === `render:if` || name === 'v-if' || name === '*if';
}
export function isMagicElifAttr(name: string) {
return name === `${pseudoNamespacePrefix}elif` || name === `render:elif` || name === 'v-else-if';
return name === `${pseudoNamespacePrefix}elif` || name === `render:elif` || name === 'v-else-if' || name === '*else-if';
}
export function isMagicElseAttr(name: string) {
return name === `${pseudoNamespacePrefix}else` || name === `render:else` || name === 'v-else';
return name === `${pseudoNamespacePrefix}else` || name === `render:else` || name === 'v-else' || name === '*else';
}
export function isMagicHTMLAttr(name: string) {
return name === `${pseudoNamespacePrefix}html` || name === `render:html` || name === 'v-html';
Expand Down Expand Up @@ -215,7 +215,10 @@ export function attrToTrait(attrName: string, expr: string): Traits[number] | un
}

export function isMagicForTemplateElement(elem: Element) {
return elem.hasAttribute(`${pseudoNamespacePrefix}for`) || elem.hasAttribute('v-for');
return elem.hasAttribute(`${pseudoNamespacePrefix}for`) ||
elem.hasAttribute('render:for') ||
elem.hasAttribute('v-for') ||
elem.hasAttribute('*for');
}

export const attachedEventName = `${pseudoNamespacePrefix}attached`;
Expand Down