test: avoid initial-break wait in restart-message by inoway46 · Pull Request #62060 · nodejs/node

inoway46 · 2026-03-01T15:42:47Z

Summary

Follow-up to #61773

test/parallel/test-debugger-restart-message.js can still flake on macOS unusual-path runs at the initial waitForInitialBreak(). This change syncs startup on the debugger CLI's ok connection-completion output plus the prompt.

failed CI log (main branch): https://github.com/nodejs/node/actions/runs/22545396955

Testing

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"

./tools/test.py -p actions parallel/test-debugger-restart-message
./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-restart-message
CI passes on macOS

Refs: #61762

codecov · 2026-03-01T17:04:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (6916e64) to head (eb34825).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62060      +/-   ##
==========================================
- Coverage   90.05%   90.04%   -0.02%     
==========================================
  Files         714      714              
  Lines      225242   225242              
  Branches    42579    42570       -9     
==========================================
- Hits       202843   202809      -34     
- Misses      14187    14203      +16     
- Partials     8212     8230      +18

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-03-25T21:20:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/62060
✔  Done loading data for nodejs/node/pull/62060
----------------------------------- PR info ------------------------------------
Title      test: avoid initial-break wait in restart-message (#62060)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     inoway46:fix-flaky-debugger-restart -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: avoid initial-break wait in restart-message
Committers 1
 - inoway46 <inoueyuya416@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62060
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62060
Refs: https://github.com/nodejs/node/issues/61762
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 01 Mar 2026 15:42:47 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62060#pullrequestreview-3884836184
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/23564673240

nodejs-github-bot · 2026-03-31T10:05:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72337/

nodejs-github-bot · 2026-04-01T03:54:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72381/

nodejs-github-bot · 2026-04-02T13:40:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72424/

inoway46 · 2026-04-11T03:15:32Z

Since the Windows flakiness seems better now, could you please rerun CI for this PR?

nodejs-github-bot · 2026-04-11T05:26:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72620/

inoway46 · 2026-04-26T14:34:47Z

        // For `restart`, sync on attach/prompt instead of BREAK_MESSAGE to avoid flaky races.
        // https://github.com/nodejs/node/issues/61762
        await cli.command('restart');
        await cli.waitFor(/Debugger attached\./);


Leaving this unchanged because this path has not shown the flake again since the fix two months ago.
ok may be the stronger sync point here too, but I’ll handle that in a separate PR after further investigation.

inoway46 · 2026-04-27T02:31:17Z

@cola119 @lpinca
Sorry for the extra request, but could you please re-approve this PR? I force-pushed after the previous approval, and it looks like full CI needs a fresh approval before request-ci is picked up.

nodejs-github-bot · 2026-05-10T09:49:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73317/

nodejs-github-bot · 2026-05-13T11:23:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73417/

inoway46 · 2026-05-13T12:06:16Z

I just noticed that the commit is missing the DCO sign-off, so I’ll need to amend it and force-push. Unfortunately, this will invalidate the current CI run.

Sorry for the churn, and thank you for starting the CI.

cc @cola119

Signed-off-by: inoway46 <inoueyuya416@gmail.com>

nodejs-github-bot · 2026-05-13T12:57:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73422/

inoway46 · 2026-05-16T10:25:04Z

The latest full CI has passed. Could someone land this PR when they have a chance? Thank you!

Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #62060 Refs: #61762 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>

lpinca · 2026-05-16T15:04:33Z

Landed in 3163d8a.

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 1, 2026

lpinca approved these changes Mar 3, 2026

View reviewed changes

inoway46 mentioned this pull request Mar 5, 2026

test: avoid flaky run wait in debugger restart test #62112

Merged

3 tasks

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 25, 2026

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026

cola119 approved these changes Apr 1, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026

inoway46 force-pushed the fix-flaky-debugger-restart branch from 3aa0054 to 6611c3b Compare April 26, 2026 04:46

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2026

inoway46 commented Apr 26, 2026

View reviewed changes

inoway46 requested review from cola119 and lpinca April 27, 2026 02:31

lpinca approved these changes May 5, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2026

This comment was marked as outdated.

Sign in to view

cola119 approved these changes May 10, 2026

View reviewed changes

cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2026

test: avoid initial-break wait in restart-message

eb34825

Signed-off-by: inoway46 <inoueyuya416@gmail.com>

inoway46 force-pushed the fix-flaky-debugger-restart branch from 0fa8b47 to eb34825 Compare May 13, 2026 12:09

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2026

lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 16, 2026

lpinca closed this May 16, 2026

inoway46 deleted the fix-flaky-debugger-restart branch May 16, 2026 15:42

Uh oh!

Conversation

inoway46 commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

codecov Bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Mar 25, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Apr 1, 2026

Uh oh!

nodejs-github-bot commented Apr 2, 2026

Uh oh!

inoway46 commented Apr 11, 2026

Uh oh!

nodejs-github-bot commented Apr 11, 2026

Uh oh!

inoway46 Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

inoway46 commented Apr 27, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented May 10, 2026

Uh oh!

nodejs-github-bot commented May 13, 2026

Uh oh!

inoway46 commented May 13, 2026

Uh oh!

nodejs-github-bot commented May 13, 2026

Uh oh!

inoway46 commented May 16, 2026

Uh oh!

lpinca commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

inoway46 commented Mar 1, 2026 •

edited

Loading

codecov Bot commented Mar 1, 2026 •

edited

Loading