fix(nix): set warnings as top-level config#2506
Open
Scrumplex wants to merge 1 commit intonoctalia-dev:mainfrom
Open
fix(nix): set warnings as top-level config#2506Scrumplex wants to merge 1 commit intonoctalia-dev:mainfrom
Scrumplex wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Contributor
Author
|
CC @linusammon |
linusammon
approved these changes
Apr 20, 2026
Contributor
linusammon
left a comment
linusammon
left a comment
There was a problem hiding this comment.
Okay, wow. Definitely not my proudest moment, thanks for fixing that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
#2495 broke the systemd feature in the Home-Manager module by setting the invalid option
systemd.user.services.noctalia-shell.warnings, which doesn't exist.This PR fixes that by setting the top-level module option
warningsusingmkIf.Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
If applicable, include screenshots or videos to help illustrate your changes.
Checklist
Additional Notes
Add any additional context or follow-up notes for reviewers.