Fix: replace Screen with Quickshell.screens[0] in WallpaperService#2409
Open
kermeat wants to merge 1 commit intonoctalia-dev:mainfrom
Open
Fix: replace Screen with Quickshell.screens[0] in WallpaperService#2409kermeat wants to merge 1 commit intonoctalia-dev:mainfrom
kermeat wants to merge 1 commit intonoctalia-dev:mainfrom
Conversation
When display turned off and on compositor recreate screen object but Screen still points to old object which no longer exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
When display turned off and on compositor recreate screen object but Screen still points to old object which no longer exists. WallpaperService tries to get Screen.name, but it's empty.
Quickshell.screens[0]is already used in some parts of WallpaperService.Type of Change
Mark the relevant option with an "x".
Related Issue
quickshell-mirror/quickshell#477
Testing
Checklist
Additional Notes
Objects after display turned off/on
Quickshell.screens[0]:QScreen(0x7f9e55944370, name="DP-3"))Screen:QQuickScreenAttached(0x7f9e1d24eb30) name: model: mnfrr: orientation: 0