Add Ethernet disconnect/reconnect functionality#2398
Open
Gualidan wants to merge 8 commits intonoctalia-dev:mainfrom
Open
Add Ethernet disconnect/reconnect functionality#2398Gualidan wants to merge 8 commits intonoctalia-dev:mainfrom
Gualidan wants to merge 8 commits intonoctalia-dev:mainfrom
Conversation
- Added connectEthernet() and disconnectEthernet() methods to NetworkService - Added Ethernet connect/disconnect processes with proper state management - Added disconnect and reconnect buttons to Ethernet interface UI - Added missing toast.wifi translations for consistent notification format - Reuses existing translation patterns for efficiency The implementation provides full Ethernet connection control similar to WiFi, with proper user feedback and state management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
Huge inconvenience to have to use the cli to disconnect from Ethernet.
Type of Change
Mark the relevant option with an "x".
Related Issue
Testing
Describe how you tested your changes and mark the relevant items.
Screenshots / Videos
If applicable, include screenshots or videos to help illustrate your changes.
Checklist
Additional Notes
Add any additional context or follow-up notes for reviewers.